From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rob Herring <robh@kernel.org>
Cc: Raja Mani <rmani@qti.qualcomm.com>, <devicetree@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ath10k@lists.infradead.org>,
<agross@codeaurora.org>
Subject: Re: [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block
Date: Thu, 21 Jan 2016 13:46:02 +0200 [thread overview]
Message-ID: <87y4bjyx39.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160115022021.GA27099@rob-hp-laptop> (Rob Herring's message of "Thu, 14 Jan 2016 20:20:21 -0600")
Rob Herring <robh@kernel.org> writes:
> On Wed, Jan 13, 2016 at 11:26:44AM +0530, Raja Mani wrote:
>> Add device tree binding documentation details for wifi block present
>> in Qualcomm IPQ4019 SoC into "qcom,ath10k.txt".
>>
>> Right now, ath10k wireless driver has support for PCI based wlan devices.
>> There is a plan to extend ath10k driver to support wifi devices which are
>> connected over AHB as well (enumeration will happen via device tree node).
>> For AHB based devices (ie, ipq4019), all wifi properties are supplied via
>> device tree (including irq, reg addr, cal data,etc).
>>
>> Signed-off-by: Raja Mani <rmani@qti.qualcomm.com>
>> ---
>> v3 changes:
>> - Removed core-id - [Rob]
>> - Documented which compatible string corresponds to pci devices
>> and which corresponds to ahb devices. - [Rob]
>>
>> v2 changes:
>> - Improved "core-id" description - [Rob]
>> - Removed "status" documentation - [Rob]
>> - Added description which properties are applicable
>> for ahb and which are applicable for pci devices - [Rob]
>> - Improved commit msg to explain the context.
>> - Renamed "qca,msi_addr" to "qcom,msi_addr" and
>> "qca,msi_base" to "qcom,msi_base" to follow uniformity.
>>
>> .../bindings/net/wireless/qcom,ath10k.txt | 89 ++++++++++++++++++++--
>> 1 file changed, 84 insertions(+), 5 deletions(-)
>
> A few typos, otherwise:
>
> Acked-by: Rob Herring <robh@kernel.org>
Rob, thank you for the review. I fixed the typos in ath.git pending
branch and will properly apply this in few days.
--
Kalle Valo
next prev parent reply other threads:[~2016-01-21 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 5:56 [PATCH v3] dt: bindings: add bindings for ipq4019 wifi block Raja Mani
2016-01-15 2:20 ` Rob Herring
2016-01-21 11:46 ` Kalle Valo [this message]
2016-01-26 15:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4bjyx39.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=agross@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmani@qti.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox