From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Luca Coelho <luca@coelho.fi>
Cc: <ath10k@lists.infradead.org>, <ath9k-devel@venema.h4ckr.net>,
<linux-wireless@vger.kernel.org>, <michal.kazior@tieto.com>
Subject: Re: [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks
Date: Fri, 16 May 2014 17:26:13 +0300 [thread overview]
Message-ID: <87y4y13im2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1400248534-16763-1-git-send-email-luca@coelho.fi> (Luca Coelho's message of "Fri, 16 May 2014 16:55:34 +0300")
Luca Coelho <luca@coelho.fi> writes:
> From: Luciano Coelho <luciano.coelho@intel.com>
>
> The channel_switch_beacon callback is optional, so it doesn't have to
> be defined if it's not going to do anything useful with it. Both
> ath9k and ath10k define the callback and just returns. This commit
> removes them.
>
> Cc: Michal Kazior <michal.kazior@tieto.com>
> Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> ---
>
> I'm plannnig to remove the channel_switch_beacon callback (actually,
> replace it with a more generic one that can be used for STA and other
> iftypes too) and ath9k/ath10k are the only (non) users of it. ;)
John, I'm planning to take this as I think we will get less conflicts
that way. But let me know if you want it instead.
--
Kalle Valo
next prev parent reply other threads:[~2014-05-16 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 13:55 [PATCH] ath9k/ath10k: remove unnecessary channel_switch_beacon callbacks Luca Coelho
2014-05-16 14:26 ` Kalle Valo [this message]
2014-05-16 15:34 ` John W. Linville
2014-05-16 15:54 ` Kalle Valo
2014-05-23 8:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4y13im2.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).