From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: refactor monitor code
Date: Tue, 8 Apr 2014 09:42:01 +0300 [thread overview]
Message-ID: <87y4zgmifa.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1396610305-5229-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 4 Apr 2014 13:18:25 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> It was possible to create/delete/start/stop
> monitor vdev from a few places that were not
> exclusively protected against each other. This
> resulted in monitor vdev being stopped/removed by
> one call origin while another one was expecting it
> to continue running.
>
> For example if CAC was started and interface's
> promiscuous mode was toggled monitor vdev was
> removed from the driver meaning no radar would be
> detected. In additional a warning would be printed
> upon CAC completion complaining it tried to stop
> non-running monitor vdev.
>
> The patch simplifies monitor code by removing
> IEEE80211_HW_WANT_MONITOR_VIF (which wasn't really
> ever needed) and improves state tracking. It also
> unifies prints.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, applied.
--
Kalle Valo
next prev parent reply other threads:[~2014-04-08 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:18 [PATCH] ath10k: refactor monitor code Michal Kazior
2014-04-08 6:42 ` Kalle Valo [this message]
2014-04-08 6:53 ` Kalle Valo
2014-04-08 7:03 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4zgmifa.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox