From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/4 v2] ath10k: add debugging for tx-credits usage
Date: Tue, 25 Mar 2014 13:59:12 +0200 [thread overview]
Message-ID: <87y4zy1obz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395688844-24640-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Mon, 24 Mar 2014 12:20:40 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> This helps track tx credits accounting and usage. If
> firmware hangs or otherwise fails to return credits, one
> can more easily see the last few command types that
> was sent to the firmware.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> v2: Improve comments. Issue of using __LINE__ is not resolved.
I'm going to drop this patch 1 for now, I'm not really fond of the idea
using line numbers in debug messages. Hopefully we find an alternative
solution, like what Michal proposed.
--
Kalle Valo
prev parent reply other threads:[~2014-03-25 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 19:20 [PATCH 1/4 v2] ath10k: add debugging for tx-credits usage greearb
2014-03-24 19:20 ` [PATCH 2/4 v2] ath10k: better firmware loading error messages greearb
2014-03-28 7:43 ` Kalle Valo
2014-03-24 19:20 ` [PATCH 3/4 v2] ath10k: add otp and firmware boot " greearb
2014-03-24 19:20 ` [PATCH 4/4 v2] ath10k: invalid msdu-id logging greearb
2014-03-25 12:02 ` Kalle Valo
2014-03-25 15:56 ` Ben Greear
2014-03-25 11:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4zy1obz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).