* [PATCH] ath10k: remove excessive rx msdu len check
@ 2014-02-11 7:37 Bartosz Markowski
2014-02-13 14:48 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Markowski @ 2014-02-11 7:37 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Bartosz Markowski
This throw a lot of pointless warnings in case of DFS (radar
detection) and PHYERR events from firmware, when firmware may
actually insert more data, than we assume.
Besides of being noisy this debug does not protect or check
anything usefull currently. It was introduced long time ago
while debugging aggregations. So just removing it.
Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index fe8bd1b..f57f5cf 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -430,12 +430,6 @@ static int ath10k_htt_rx_amsdu_pop(struct ath10k_htt *htt,
msdu_chaining = 1;
}
- if (msdu_len > 0) {
- /* This may suggest FW bug? */
- ath10k_warn("htt rx msdu len not consumed (%d)\n",
- msdu_len);
- }
-
last_msdu = __le32_to_cpu(rx_desc->msdu_end.info0) &
RX_MSDU_END_INFO0_LAST_MSDU;
--
1.7.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k: remove excessive rx msdu len check
2014-02-11 7:37 [PATCH] ath10k: remove excessive rx msdu len check Bartosz Markowski
@ 2014-02-13 14:48 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2014-02-13 14:48 UTC (permalink / raw)
To: Bartosz Markowski; +Cc: ath10k, linux-wireless
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> This throw a lot of pointless warnings in case of DFS (radar
> detection) and PHYERR events from firmware, when firmware may
> actually insert more data, than we assume.
>
> Besides of being noisy this debug does not protect or check
> anything usefull currently. It was introduced long time ago
> while debugging aggregations. So just removing it.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-13 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-11 7:37 [PATCH] ath10k: remove excessive rx msdu len check Bartosz Markowski
2014-02-13 14:48 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).