public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] mac80211: move VHT related RX_FLAG to another variable
Date: Wed, 5 Feb 2014 15:52:50 +0200	[thread overview]
Message-ID: <87y51pk6od.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CANUX_P2Z+FTZz83D5HR7w9z3F3=nhP8p_4wRb-5XBe0kv1vu2A@mail.gmail.com> (Emmanuel Grumbach's message of "Wed, 5 Feb 2014 15:49:11 +0200")

Emmanuel Grumbach <egrumbach@gmail.com> writes:

> On Wed, Feb 5, 2014 at 3:41 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:
>>
>>> ieee80211_rx_status.flags is full. Define a new vht_flag
>>> variable to be able to set more VHT related flags and make
>>> room in flags.
>>>
>>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>>
>> [...]
>>
>>> @@ -866,9 +863,6 @@ enum mac80211_rx_flags {
>>>       RX_FLAG_AMPDU_DELIM_CRC_KNOWN   = BIT(20),
>>>       RX_FLAG_MACTIME_END             = BIT(21),
>>>       RX_FLAG_VHT                     = BIT(22),
>>> -     RX_FLAG_80MHZ                   = BIT(23),
>>> -     RX_FLAG_80P80MHZ                = BIT(24),
>>> -     RX_FLAG_160MHZ                  = BIT(25),
>>
>> Doesn't this break ath10k?
>
> yep it does... It seems that I need to run with a few more drivers enabled :)

For changes like this allmodconfig is your best friend ;)

-- 
Kalle Valo

  reply	other threads:[~2014-02-05 13:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 10:48 [PATCH 1/3] mac80211: remove unused radiotap vendor fields in ieee80211_rx_status Emmanuel Grumbach
2014-02-05 10:48 ` [PATCH 2/3] mac80211: move VHT related RX_FLAG to another variable Emmanuel Grumbach
2014-02-05 13:41   ` Kalle Valo
2014-02-05 13:49     ` Emmanuel Grumbach
2014-02-05 13:52       ` Kalle Valo [this message]
2014-02-05 10:48 ` [PATCH 3/3] mac80211: propagate STBC / LDPC flags to radiotap Emmanuel Grumbach
2014-02-06  8:35   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y51pk6od.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=egrumbach@gmail.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox