* [PATCH v2] ath10k: leave MMIC generation to the HW
[not found] <1372060350-31460-4-git-send-email-michal.kazior@tieto.com>
@ 2013-06-26 6:57 ` Michal Kazior
2013-07-05 13:25 ` [ath9k-devel] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Michal Kazior @ 2013-06-26 6:57 UTC (permalink / raw)
To: ath9k-devel, linux-wireless; +Cc: Michal Kazior
Apparently HW doesn't require us to generate MMIC
for TKIP suite.
Each frame was 8 bytes longer than it should be
and some APs would drop frames that exceed 1520
bytes of 802.11 payload. This could be observed
during throughput tests or fragmented IP traffic.
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 4867f30..bfee06d 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -56,7 +56,6 @@ static int ath10k_send_key(struct ath10k_vif *arvif,
key->flags |= IEEE80211_KEY_FLAG_SW_MGMT_TX;
break;
case WLAN_CIPHER_SUITE_TKIP:
- key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC;
arg.key_cipher = WMI_CIPHER_TKIP;
arg.key_txmic_len = 8;
arg.key_rxmic_len = 8;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ath9k-devel] [PATCH v2] ath10k: leave MMIC generation to the HW
2013-06-26 6:57 ` [PATCH v2] ath10k: leave MMIC generation to the HW Michal Kazior
@ 2013-07-05 13:25 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2013-07-05 13:25 UTC (permalink / raw)
To: Michal Kazior; +Cc: ath9k-devel, linux-wireless
Michal Kazior <michal.kazior@tieto.com> writes:
> Apparently HW doesn't require us to generate MMIC
> for TKIP suite.
>
> Each frame was 8 bytes longer than it should be
> and some APs would drop frames that exceed 1520
> bytes of 802.11 payload. This could be observed
> during throughput tests or fragmented IP traffic.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
This is also applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-05 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1372060350-31460-4-git-send-email-michal.kazior@tieto.com>
2013-06-26 6:57 ` [PATCH v2] ath10k: leave MMIC generation to the HW Michal Kazior
2013-07-05 13:25 ` [ath9k-devel] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).