From: Kalle Valo <kvalo@adurom.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl1251: read default MAC address from EEPROM when available
Date: Wed, 14 Apr 2010 10:08:23 +0300 [thread overview]
Message-ID: <87y6gqmryw.fsf@purkki.valot.fi> (raw)
In-Reply-To: <q2k6ed0b2681004131434ma73a9d77yf13e2469e8c49def@mail.gmail.com> (Grazvydas Ignotas's message of "Wed\, 14 Apr 2010 00\:34\:28 +0300")
Grazvydas Ignotas <notasas@gmail.com> writes:
>>> + udelay(200);
>>> + }
>>
>> Is the udelay() really needed here? In my opinion msleep(), for
>> example with a value of 5 ms, would be nicer from system point of
>> view. It doesn't matter if this function takes few milliseconds
>> longer, because this is called only in op_start(). What do you think?
>
> It normally takes something like 700-1000us, so I guess I can replace
> with msleep(1) if you think it's better.
Yes, that's better. It's always good to avoid busylooping.
--
Kalle Valo
prev parent reply other threads:[~2010-04-14 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 22:21 [PATCH] wl1251: read default MAC address from EEPROM when available Grazvydas Ignotas
2010-04-13 17:05 ` Kalle Valo
2010-04-13 21:34 ` Grazvydas Ignotas
2010-04-14 7:08 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6gqmryw.fsf@purkki.valot.fi \
--to=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).