public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: add driver ops wrappers
Date: Fri, 24 Apr 2009 08:37:49 +0300	[thread overview]
Message-ID: <87y6tqd32q.fsf@litku.valot.fi> (raw)
In-Reply-To: <1240505572.30082.233.camel@johannes.local> (Johannes Berg's message of "Thu\, 23 Apr 2009 18\:52\:52 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:

> In order to later add tracing or verifications to the driver
> calls mac80211 makes, this patch adds static inline wrappers
> for all operations.
>
> All calls are now written as
>
> 	drv_<op>(local, ...);
>
> instead of
>
> 	local->ops-><op>(&local->hw, ...);
>
> Where necessary, the wrappers also do existence checking and
> return default values as appropriate.

Also grepping is easier this way. I think this is a good change to have,
especially I'm interested of tracing driver calls. Until now I have
added debug messages to all drivers I maintain.

But I'm just concerned about the drv prefix, with very bad luck it might
create conflicts with some other component. What about using
ieee80211_drv, for example?

-- 
Kalle Valo

  reply	other threads:[~2009-04-24  5:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-23 16:52 [PATCH] mac80211: add driver ops wrappers Johannes Berg
2009-04-24  5:37 ` Kalle Valo [this message]
2009-04-24  9:23   ` Johannes Berg
2009-04-24 14:00     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6tqd32q.fsf@litku.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox