From: Kalle Valo <kalle.valo@iki.fi>
To: Michael Buesch <mb@bu3sch.de>
Cc: "Alina Friedrichsen" <x-alina@gmx.net>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: Give it some time to do the TSF sync
Date: Sun, 22 Feb 2009 08:45:51 +0200 [thread overview]
Message-ID: <87y6vz2cm8.fsf@litku.valot.fi> (raw)
In-Reply-To: <200902212302.15056.mb@bu3sch.de> (Michael Buesch's message of "Sat\, 21 Feb 2009 23\:02\:14 +0100")
Michael Buesch <mb@bu3sch.de> writes:
> On Saturday 21 February 2009 22:52:02 Alina Friedrichsen wrote:
>> Give slow hardware some time to do the TSF sync, to not run into an IBSS merging endless loop in some rarely situations.
>
> It would be great to put this into a source code comment. Without
> this knowledge one immediately gets a WTF-lookalike face when seeing
> this code.
I fully agree.
>> - if (beacon_timestamp > rx_timestamp) {
>> + if (beacon_timestamp > rx_timestamp && rx_timestamp > 0x400000) {
And no magic numbers, please. Create a define for that.
--
Kalle Valo
prev parent reply other threads:[~2009-02-22 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 21:52 [PATCH] mac80211: Give it some time to do the TSF sync Alina Friedrichsen
2009-02-21 22:02 ` Michael Buesch
2009-02-22 6:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6vz2cm8.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).