linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: ath12k@lists.infradead.org,  linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/7] wifi: ath12k: rename mlo_capable_flags to single_chip_mlo_supp
Date: Fri, 06 Dec 2024 09:47:37 +0200	[thread overview]
Message-ID: <87zfl9jlra.fsf@kernel.org> (raw)
In-Reply-To: <88e0116c-778f-4861-8751-b30a09d3d2b4@oss.qualcomm.com> (Jeff Johnson's message of "Thu, 5 Dec 2024 14:32:38 -0800")

Jeff Johnson <jeff.johnson@oss.qualcomm.com> writes:

> On 12/4/2024 8:32 AM, Kalle Valo wrote:
>
>> From: Aditya Kumar Singh <quic_adisi@quicinc.com>
>> 
>> At present, the mlo_capable_flags in ath12k_base is used to indicate whether
>> the chip supports inter (QCN9274) or intra (WCN7850) chip MLO. However, it’s
>> possible that the chip supports neither, especially with older firmware
>> versions. Additionally, if intra chip MLO is not supported, inter chip MLO will
>> also be non-functional. Therefore, having two separate flags for this is
>> unnecessary.
>> 
>> Therefore, rename this flag to single_chip_mlo_supp. At the same time convert
>> it into a bool data type. Also, get rid of the enums defined earlier.
>> 
>> For the QCN9274 family of chipsets, this will be set only when firmware
>> advertises the support during the QMI exchange.
>> 
>> For the WCN7850 family of chipsets, since the event is not supported,
>> assumption is made that single chip MLO is supported.
>> 
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>> 
>> Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
>
> Kalle, this patch is missing your SOB.
> Please reply with the tag and I'll fix in 'pending'

Oh darn, sorry about that. Here it is:

Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2024-12-06  7:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 16:32 [PATCH 0/7] wifi: ath12k: MLO support part 6 Kalle Valo
2024-12-04 16:32 ` [PATCH 1/7] wifi: ath12k: move ATH12K_FLAG_REGISTERED handling to ath12k_mac_register() Kalle Valo
2024-12-04 16:32 ` [PATCH 2/7] wifi: ath12k: rename mlo_capable_flags to single_chip_mlo_supp Kalle Valo
2024-12-05 22:32   ` Jeff Johnson
2024-12-06  7:47     ` Kalle Valo [this message]
2024-12-04 16:32 ` [PATCH 3/7] wifi: ath12k: introduce device group abstraction Kalle Valo
2024-12-04 16:32 ` [PATCH 4/7] wifi: ath12k: refactor core start based on hardware group Kalle Valo
2024-12-04 16:32 ` [PATCH 5/7] wifi: ath12k: move struct ath12k_hw from per device to group Kalle Valo
2024-12-10 20:58   ` Kees Bakker
2024-12-10 22:57     ` Jeff Johnson
2024-12-04 16:32 ` [PATCH 6/7] wifi: ath12k: send QMI host capability after device group is ready Kalle Valo
2024-12-04 16:32 ` [PATCH 7/7] wifi: ath12k: introduce mlo_capable flag for device group Kalle Valo
2024-12-06 15:42 ` [PATCH 0/7] wifi: ath12k: MLO support part 6 Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfl9jlra.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).