linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] wifi: rtw89: Remove unneeded variable
       [not found] ` <a4bd77fc102a60ebac4e036842015eac@208suo.com>
@ 2023-06-10 13:38   ` Kalle Valo
  2023-06-14  6:28   ` xuanzhenggang001
  1 sibling, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-06-10 13:38 UTC (permalink / raw)
  To: xuanzhenggang001; +Cc: pkshih, linux-wireless, linux-kernel

xuanzhenggang001@208suo.com writes:

> Fix the following coccicheck warning:
>
> drivers/net/wireless/realtek/rtw89/pci.c:239:5-8: Unneeded variable: "cnt".
>
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com>

No HTML emails, please. I recommend using 'git send-email' tool for
submitting patches, more info in the wiki below.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] wifi: rtw89: Remove unneeded variable
       [not found] ` <a4bd77fc102a60ebac4e036842015eac@208suo.com>
  2023-06-10 13:38   ` [PATCH] wifi: rtw89: Remove unneeded variable Kalle Valo
@ 2023-06-14  6:28   ` xuanzhenggang001
  1 sibling, 0 replies; 2+ messages in thread
From: xuanzhenggang001 @ 2023-06-14  6:28 UTC (permalink / raw)
  To: pkshih, kvalo; +Cc: linux-wireless, linux-kernel

Fix the following coccicheck warning:

drivers/net/wireless/realtek/rtw89/pci.c:239:5-8: Unneeded variable: 
"cnt".

Signed-off-by: Zhenggang Xuan <xuanzhenggang001@208suo.com>
---
  drivers/net/wireless/realtek/rtw89/pci.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/pci.c 
b/drivers/net/wireless/realtek/rtw89/pci.c
index 9402f1a0caea..591b7b9a6eca 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -236,7 +236,6 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct 
rtw89_dev *rtwdev,
      struct sk_buff *skb;
      u32 rxinfo_size = sizeof(struct rtw89_pci_rxbd_info);
      u32 offset;
-    u32 cnt = 1;
      bool fs, ls;
      int ret;

@@ -297,7 +296,7 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct 
rtw89_dev *rtwdev,
          desc_info->ready = false;
      }

-    return cnt;
+    return 1;

  err_sync_device:
      rtw89_pci_sync_skb_for_device(rtwdev, skb);
@@ -308,7 +307,7 @@ static u32 rtw89_pci_rxbd_deliver_skbs(struct 
rtw89_dev *rtwdev,
      rx_ring->diliver_skb = NULL;
      desc_info->ready = false;

-    return cnt;
+    return 1;
  }

  static void rtw89_pci_rxbd_deliver(struct rtw89_dev *rtwdev,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-14  6:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230610131734.21134-1-denghuilong@cdjrlc.com>
     [not found] ` <a4bd77fc102a60ebac4e036842015eac@208suo.com>
2023-06-10 13:38   ` [PATCH] wifi: rtw89: Remove unneeded variable Kalle Valo
2023-06-14  6:28   ` xuanzhenggang001

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).