From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB4AC6FD1C for ; Fri, 24 Mar 2023 07:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbjCXHRV (ORCPT ); Fri, 24 Mar 2023 03:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbjCXHRR (ORCPT ); Fri, 24 Mar 2023 03:17:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BEDE10248 for ; Fri, 24 Mar 2023 00:17:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3133662976 for ; Fri, 24 Mar 2023 07:17:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B671C4339B; Fri, 24 Mar 2023 07:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679642231; bh=aGztGcU7/fjAKFTZAFnUoTbI71Po/UtViDXqfGt4488=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KQGlvGpj6elZt0523wrFhTL92OMKKxsaOgo49VeIjmAkTHlD0n6d4ELMXy3mjt79S VWuBtihNt1UqBKdSGtFlQRgY1BG3L5tZQwwkvBmYjK1fVBt9/qHvJll2iyXaGetLLv TcVxRNoBvQBcPiRugkpXXCRXdAU8TZEjQLWHo6qcXldcP2E8MHSDiMiuoC3niAQY6H zhauftEKZL1BNT8jf7XRSBQAkGTxJuOL+Mhzytu0+sGNW4vXoCDWRjhWGsFUPLH0KB OKwG90BwSHY3CV/v/GiWL7XXRTf7//7kQ0C6SPEwp8WcmV3cPV1keky+mlktfaCoeq 6FqXhqIycm7Cg== From: Kalle Valo To: Felix Fietkau Cc: Lorenzo Bianconi , linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, Ben Greear Subject: Re: [PATCH v3] wireless: mt76: mt7921: Fix use-after-free in fw features query. References: <51fd8f76494348aa9ecbf0abc471ebe47a983dfd.1679502607.git.lorenzo@kernel.org> Date: Fri, 24 Mar 2023 09:17:08 +0200 In-Reply-To: (Felix Fietkau's message of "Wed, 22 Mar 2023 21:58:36 +0100") Message-ID: <87zg82ty8b.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > On 22.03.23 17:37, Lorenzo Bianconi wrote: >> From: Ben Greear >> >> Stop referencing 'features' memory after release_firmware is called. >> >> Fixes this crash: >> >> RIP: 0010:mt7921_check_offload_capability+0x17d >> mt7921_pci_probe+0xca/0x4b0 >> ... >> >> Signed-off-by: Ben Greear >> Signed-off-by: Lorenzo Bianconi The title should have "wifi:", not "wireless:". > Acked-by: Felix Fietkau Felix, do you mean I should take this to wireless tree? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches