linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Shayne Chen <shayne.chen@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	Bo Jiao <Bo.Jiao@mediatek.com>,
	linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 5/9] wifi: mt76: mt7996: add MAC support
Date: Thu, 01 Dec 2022 12:39:07 +0200	[thread overview]
Message-ID: <87zgc7mmr8.fsf@kernel.org> (raw)
In-Reply-To: <20221122084554.9494-6-shayne.chen@mediatek.com> (Shayne Chen's message of "Tue, 22 Nov 2022 16:45:50 +0800")

Shayne Chen <shayne.chen@mediatek.com> writes:

> (Split the big patch into smaller intermediate patches by functionality
> for easier review. Refer to the cover letter for more info.)
>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>

[...]

> +static void mt7996_mac_sta_poll(struct mt7996_dev *dev)
> +{
> +	static const u8 ac_to_tid[] = {
> +		[IEEE80211_AC_BE] = 0,
> +		[IEEE80211_AC_BK] = 1,
> +		[IEEE80211_AC_VI] = 4,
> +		[IEEE80211_AC_VO] = 6
> +	};
> +	struct ieee80211_sta *sta;
> +	struct mt7996_sta *msta;
> +	struct rate_info *rate;
> +	u32 tx_time[IEEE80211_NUM_ACS], rx_time[IEEE80211_NUM_ACS];
> +	LIST_HEAD(sta_poll_list);
> +	int i;
> +
> +	spin_lock_bh(&dev->sta_poll_lock);
> +	list_splice_init(&dev->sta_poll_list, &sta_poll_list);
> +	spin_unlock_bh(&dev->sta_poll_lock);
> +
> +	rcu_read_lock();
> +
> +	while (true) {

In upstream we have a preference that there's some kind of limit for
loops, to avoid neverending loops.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-12-01 10:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  8:45 [PATCH 0/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices Shayne Chen
2022-11-22  8:45 ` [PATCH 1/9] wifi: mt76: mt7996: add PCI support Shayne Chen
2022-11-22  8:45 ` [PATCH 2/9] wifi: mt76: mt7996: add DMA support Shayne Chen
2022-11-22  8:45 ` [PATCH 3/9] wifi: mt76: mt7996: add MCU support Shayne Chen
2022-11-22  8:45 ` [PATCH 4/9] wifi: mt76: mt7996: add EEPROM support Shayne Chen
2022-11-22  8:45 ` [PATCH 5/9] wifi: mt76: mt7996: add MAC support Shayne Chen
2022-12-01 10:39   ` Kalle Valo [this message]
2022-12-01 10:51     ` Felix Fietkau
2022-11-22  8:45 ` [PATCH 6/9] wifi: mt76: mt7996: add ieee80211_ops Shayne Chen
2022-11-22  8:45 ` [PATCH 7/9] wifi: mt76: mt7996: add debugfs support Shayne Chen
2022-11-22  8:45 ` [PATCH 8/9] wifi: mt76: mt7996: add module support Shayne Chen
2022-11-22  8:45 ` [PATCH 9/9] wifi: mt76: add mt7996 " Shayne Chen
2022-11-24  8:06 ` [PATCH 0/9] wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices Kalle Valo
2022-11-24 10:27   ` shayne.chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgc7mmr8.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=Bo.Jiao@mediatek.com \
    --cc=evelyn.tsai@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).