From: Kalle Valo <kvalo@kernel.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
linux-wireless@vger.kernel.org, stable@vger.kernel.org,
"Gregory Erwin" <gregerwin256@gmail.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Eric W . Biederman" <ebiederm@xmission.com>,
vschneid@redhat.com
Subject: Re: [PATCH RESEND v11] hwrng: core - let sleep be interrupted when unregistering hwrng
Date: Wed, 27 Jul 2022 09:32:20 +0300 [thread overview]
Message-ID: <87zggvoykr.fsf@kernel.org> (raw)
In-Reply-To: <Yt+/HvfC+OYRVrr+@zx2c4.com> (Jason A. Donenfeld's message of "Tue, 26 Jul 2022 12:17:02 +0200")
"Jason A. Donenfeld" <Jason@zx2c4.com> writes:
> On Tue, Jul 26, 2022 at 05:44:41PM +0800, Herbert Xu wrote:
>> Thanks for all your effort in resolving this issue.
>>
>> I think Valentin's concern is valid though. The sleep/wakeup paradigm
>> in this patch-set is slightly unusual.
>>
>> So what I've done is taken your latest patch, and incorporated
>> Valentin's suggestions on top of it. I don't think there is an
>> issue with other drivers as neither approach really changes them.
>
> Thanks so much for taking charge of this patch. I really, really
> appreciate it. I'm also glad that we now have a working implementation
> of Valentin's suggestion.
>
> Just two small notes:
> - I had a hard time testing everything because I don't actually have an
> ath9k, so I wound up playing with variations on
> https://xn--4db.cc/vnRj8zQw/diff in case that helps. I assume you've
> got your own way of testing things, but in case not, maybe that diff
> is useful.
> - I'll mark this patch as "other tree" in the wireless tree's patchwork
> now that you're on board so Kalle doesn't have to deal with it.
Please don't touch linux-wireless patchwork project, if other people
modify it we don't know what's happening. I prefer that I handle the
patches myself in patchwork as that way I'm best up-to-date.
But just so that I understand correctly, after Herbert's patch no ath9k
changes is needed anymore? That sounds great.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-07-27 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 21:55 [PATCH RESEND v10] ath9k: let sleep be interrupted when unregistering hwrng Jason A. Donenfeld
2022-07-26 9:44 ` [PATCH RESEND v11] hwrng: core - " Herbert Xu
2022-07-26 10:17 ` Jason A. Donenfeld
2022-07-26 11:32 ` Valentin Schneider
2022-07-27 6:32 ` Kalle Valo [this message]
2022-07-27 8:34 ` Herbert Xu
2022-07-27 8:44 ` Kalle Valo
2022-07-27 8:50 ` Herbert Xu
2022-07-27 9:01 ` Herbert Xu
2022-07-28 10:22 ` [v12 PATCH] " Herbert Xu
2022-07-28 12:39 ` Toke Høiland-Jørgensen
2022-07-28 13:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zggvoykr.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ebiederm@xmission.com \
--cc=gregerwin256@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=toke@toke.dk \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).