* [PATCH] iw: info: print missing extended feature flag information
@ 2020-01-01 17:48 Markus Theil
2020-01-06 11:16 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: Markus Theil @ 2020-01-01 17:48 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Markus Theil
Some extended feature flags were not considered before.
Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
---
info.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/info.c b/info.c
index 38362d8..0f24dae 100644
--- a/info.c
+++ b/info.c
@@ -676,7 +676,17 @@ broken_combination:
ext_feat_print(tb, DFS_OFFLOAD, "DFS offload");
ext_feat_print(tb, CONTROL_PORT_OVER_NL80211,
"control port over nl80211");
+ ext_feat_print(tb, ACK_SIGNAL_SUPPORT,
+ "ack signal level support");
ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs");
+ ext_feat_print(tb, SCAN_RANDOM_SN,
+ "use random sequence numbers in scans");
+ ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT,
+ "use probe request with only rate IEs in scans");
+ ext_feat_print(tb, CAN_REPLACE_PTK0,
+ "can safely replace PTK 0 when rekeying");
+ ext_feat_print(tb, ENABLE_FTM_RESPONDER,
+ "enable FTM (Fine Time Measurement) responder");
ext_feat_print(tb, AIRTIME_FAIRNESS,
"airtime fairness scheduling");
ext_feat_print(tb, AP_PMKSA_CACHING,
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iw: info: print missing extended feature flag information
2020-01-01 17:48 [PATCH] iw: info: print missing extended feature flag information Markus Theil
@ 2020-01-06 11:16 ` Toke Høiland-Jørgensen
2020-01-06 11:37 ` Markus Theil
0 siblings, 1 reply; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-01-06 11:16 UTC (permalink / raw)
To: Markus Theil, johannes; +Cc: linux-wireless, Markus Theil
Markus Theil <markus.theil@tu-ilmenau.de> writes:
> Some extended feature flags were not considered before.
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> ---
> info.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/info.c b/info.c
> index 38362d8..0f24dae 100644
> --- a/info.c
> +++ b/info.c
> @@ -676,7 +676,17 @@ broken_combination:
> ext_feat_print(tb, DFS_OFFLOAD, "DFS offload");
> ext_feat_print(tb, CONTROL_PORT_OVER_NL80211,
> "control port over nl80211");
> + ext_feat_print(tb, ACK_SIGNAL_SUPPORT,
> + "ack signal level support");
> ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs");
> + ext_feat_print(tb, SCAN_RANDOM_SN,
> + "use random sequence numbers in scans");
> + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT,
> + "use probe request with only rate IEs in scans");
> + ext_feat_print(tb, CAN_REPLACE_PTK0,
> + "can safely replace PTK 0 when rekeying");
> + ext_feat_print(tb, ENABLE_FTM_RESPONDER,
> + "enable FTM (Fine Time Measurement) responder");
> ext_feat_print(tb, AIRTIME_FAIRNESS,
> "airtime fairness scheduling");
I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other.
Also, while you're at it, could you please add the newly-added AQL
feature? Something like
ext_feat_print(tb, AIRTIME_FAIRNESS,
"airtime fairness scheduling");
+ ext_feat_print(tb, AQL,
+ "Airtime Queue Limits (AQL)");
-Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iw: info: print missing extended feature flag information
2020-01-06 11:16 ` Toke Høiland-Jørgensen
@ 2020-01-06 11:37 ` Markus Theil
2020-01-06 11:42 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 4+ messages in thread
From: Markus Theil @ 2020-01-06 11:37 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, johannes; +Cc: linux-wireless
On 1/6/20 12:16 PM, Toke Høiland-Jørgensen wrote:
> Markus Theil <markus.theil@tu-ilmenau.de> writes:
>
>> Some extended feature flags were not considered before.
>>
>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
>> ---
>> info.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/info.c b/info.c
>> index 38362d8..0f24dae 100644
>> --- a/info.c
>> +++ b/info.c
>> @@ -676,7 +676,17 @@ broken_combination:
>> ext_feat_print(tb, DFS_OFFLOAD, "DFS offload");
>> ext_feat_print(tb, CONTROL_PORT_OVER_NL80211,
>> "control port over nl80211");
>> + ext_feat_print(tb, ACK_SIGNAL_SUPPORT,
>> + "ack signal level support");
>> ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs");
>> + ext_feat_print(tb, SCAN_RANDOM_SN,
>> + "use random sequence numbers in scans");
>> + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT,
>> + "use probe request with only rate IEs in scans");
>> + ext_feat_print(tb, CAN_REPLACE_PTK0,
>> + "can safely replace PTK 0 when rekeying");
>> + ext_feat_print(tb, ENABLE_FTM_RESPONDER,
>> + "enable FTM (Fine Time Measurement) responder");
>> ext_feat_print(tb, AIRTIME_FAIRNESS,
>> "airtime fairness scheduling");
> I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other.
>
> Also, while you're at it, could you please add the newly-added AQL
> feature? Something like
>
> ext_feat_print(tb, AIRTIME_FAIRNESS,
> "airtime fairness scheduling");
> + ext_feat_print(tb, AQL,
> + "Airtime Queue Limits (AQL)");
I'm currently working on some other small patches and will include this
and reorder the flags such that TXQS and AIRTIME_FAIRNESS will be next
to each other.
Thanks for the hint!
Markus
>
> -Toke
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iw: info: print missing extended feature flag information
2020-01-06 11:37 ` Markus Theil
@ 2020-01-06 11:42 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-01-06 11:42 UTC (permalink / raw)
To: Markus Theil, johannes; +Cc: linux-wireless
Markus Theil <markus.theil@tu-ilmenau.de> writes:
> On 1/6/20 12:16 PM, Toke Høiland-Jørgensen wrote:
>> Markus Theil <markus.theil@tu-ilmenau.de> writes:
>>
>>> Some extended feature flags were not considered before.
>>>
>>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
>>> ---
>>> info.c | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/info.c b/info.c
>>> index 38362d8..0f24dae 100644
>>> --- a/info.c
>>> +++ b/info.c
>>> @@ -676,7 +676,17 @@ broken_combination:
>>> ext_feat_print(tb, DFS_OFFLOAD, "DFS offload");
>>> ext_feat_print(tb, CONTROL_PORT_OVER_NL80211,
>>> "control port over nl80211");
>>> + ext_feat_print(tb, ACK_SIGNAL_SUPPORT,
>>> + "ack signal level support");
>>> ext_feat_print(tb, TXQS, "FQ-CoDel-enabled intermediate TXQs");
>>> + ext_feat_print(tb, SCAN_RANDOM_SN,
>>> + "use random sequence numbers in scans");
>>> + ext_feat_print(tb, SCAN_MIN_PREQ_CONTENT,
>>> + "use probe request with only rate IEs in scans");
>>> + ext_feat_print(tb, CAN_REPLACE_PTK0,
>>> + "can safely replace PTK 0 when rekeying");
>>> + ext_feat_print(tb, ENABLE_FTM_RESPONDER,
>>> + "enable FTM (Fine Time Measurement) responder");
>>> ext_feat_print(tb, AIRTIME_FAIRNESS,
>>> "airtime fairness scheduling");
>> I would prefer to keep TXQS and AIRTIME_FAIRNESS next to each other.
>>
>> Also, while you're at it, could you please add the newly-added AQL
>> feature? Something like
>>
>> ext_feat_print(tb, AIRTIME_FAIRNESS,
>> "airtime fairness scheduling");
>> + ext_feat_print(tb, AQL,
>> + "Airtime Queue Limits (AQL)");
> I'm currently working on some other small patches and will include this
> and reorder the flags such that TXQS and AIRTIME_FAIRNESS will be next
> to each other.
> Thanks for the hint!
Great, thanks! :)
-Toke
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-06 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-01 17:48 [PATCH] iw: info: print missing extended feature flag information Markus Theil
2020-01-06 11:16 ` Toke Høiland-Jørgensen
2020-01-06 11:37 ` Markus Theil
2020-01-06 11:42 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).