From: Kalle Valo <kvalo@codeaurora.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libertas: remove ifdef OLPC noise
Date: Wed, 16 Jan 2019 18:04:48 +0200 [thread overview]
Message-ID: <87zhs04mhr.fsf@codeaurora.org> (raw)
In-Reply-To: <20190116151618.1972197-1-lkundrak@v3.sk> (Lubomir Rintel's message of "Wed, 16 Jan 2019 16:16:19 +0100")
Lubomir Rintel <lkundrak@v3.sk> writes:
> <asm/olpc.h> provides machine_is_olpc() stub for CONFIG_OLPC=n,
> compiler should just optimize the unneeded bits away.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/net/wireless/marvell/libertas/if_usb.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c
> index 220dcdee8d2b..7b61c599948e 100644
> --- a/drivers/net/wireless/marvell/libertas/if_usb.c
> +++ b/drivers/net/wireless/marvell/libertas/if_usb.c
> @@ -12,9 +12,7 @@
> #include <linux/usb.h>
> #include <linux/olpc-ec.h>
>
> -#ifdef CONFIG_OLPC
> #include <asm/olpc.h>
> -#endif
Using asm directory looked odd to me so I did some investigation:
$ find -name olpc.h
./arch/x86/include/asm/olpc.h
Did you build this on something else than x86? For example, will the
compiler find olpc.h when building for arm?
--
Kalle Valo
next prev parent reply other threads:[~2019-01-16 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 15:16 [PATCH] libertas: remove ifdef OLPC noise Lubomir Rintel
2019-01-16 16:04 ` Kalle Valo [this message]
2019-01-16 16:20 ` Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhs04mhr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).