From: Kalle Valo <kvalo@codeaurora.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,
kernel list <linux-kernel@vger.kernel.org>,
davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c
Date: Mon, 10 Dec 2018 19:30:56 +0200 [thread overview]
Message-ID: <87zhtd1e7j.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181209200844.GA12756@amd> (Pavel Machek's message of "Sun, 9 Dec 2018 21:08:44 +0100")
Pavel Machek <pavel@ucw.cz> writes:
> On Mon 2018-12-03 10:45:01, Kalle Valo wrote:
>> Pavel Machek <pavel@ucw.cz> writes:
>>
>> > While grepping something else, I came across LED trigger that is named
>> > just "tx".
>> >
>> > That's a bit too generic afaict?
>> >
>> > +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
>> > @@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device
>> > *udev, u8 *buf, u32 size,
>> > static int tx_activity;
>> > static void at76_ledtrig_tx_timerfunc(struct timer_list *unused);
>> > static DEFINE_TIMER(ledtrig_tx_timer, at76_ledtrig_tx_timerfunc);
>> > -DEFINE_LED_TRIGGER(ledtrig_tx);
>> > +DEFINE_LED_TRIGGER(ledtrig_tx); /* Hey! "tx" is a bit too generic
>> > name for a trigger! */
>>
>> This is an ancient driver, my guess is that nobody uses it anymore. I
>> should orphan it and maybe even remove it at some point.
>
> Are you willing to add a fixme there? I really don't want people to
> copy that example.
Sure, patches welcome.
--
Kalle Valo
prev parent reply other threads:[~2018-12-10 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 14:31 trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c Pavel Machek
2018-12-03 8:45 ` Kalle Valo
2018-12-09 20:08 ` Pavel Machek
2018-12-10 17:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhtd1e7j.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).