From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50136 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755210AbdLGNmn (ORCPT ); Thu, 7 Dec 2017 08:42:43 -0500 From: Kalle Valo To: kbuild test robot Cc: Felix Fietkau , kbuild-all@01.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings References: <20171120193549.80831-4-nbd@nbd.name> <20171123072723.GA16326@lkp-ne02> Date: Thu, 07 Dec 2017 15:42:39 +0200 In-Reply-To: <20171123072723.GA16326@lkp-ne02> (kbuild test robot's message of "Thu, 23 Nov 2017 15:27:23 +0800") Message-ID: <87zi6uhcxc.fsf@purkki.adurom.net> (sfid-20171207_144253_892097_D878A9A2) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: kbuild test robot writes: > drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e") > CC: Felix Fietkau > Signed-off-by: Fengguang Wu I would like to apply this but the From field doesn't match the s-o-b line. This patch is created automatically, right? I think the best is that if you modify your script to add this to the beginning of the commit log: From: Fengguang Wu That way From and s-o-b match and you can continue to submit it from the lkp address. -- Kalle Valo