From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: nbd@nbd.name
Subject: Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs
Date: Tue, 05 Sep 2017 11:49:31 +0200 [thread overview]
Message-ID: <87zia91nmc.fsf@toke.dk> (raw)
In-Reply-To: <1504603125.12380.7.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Tue, 2017-09-05 at 11:02 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>>=20
>> > I'm not sure. However, I think it's less bad than one might guess
>> > since it really should only affect multicast frames, right? All
>> > unicast frames should go directly to the per-STA TXQ.
>>=20
>> Ah, right, that is the interface txq that is being purged. Gotcha.
>>=20
>> But, erm, what happens with unicast traffic sent on the VLAN
>> interface when it goes down? Shouldn't that be purged from the per-
>> station TXQs as well?
>
> Well, those entire TXQs are destroyed with the station :)
Ah, so the station is attached to the VLAN interface, not the parent
interface?
I guess that the only case where there is likely to be any significant
effects of dropping the whole queue is if someone is sending large
amounts of multicast traffic (live video streaming? is that even
feasible over WiFi?) while reconfiguring their VLAN setup. That is
probably not a terribly common combination...
-Toke
next prev parent reply other threads:[~2017-09-05 9:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 10:20 [PATCH 1/3] mac80211: agg-tx: call drv_wake_tx_queue in proper context Johannes Berg
2017-06-22 10:20 ` [PATCH 2/3] mac80211: avoid allocating TXQs that won't be used Johannes Berg
2017-06-22 10:20 ` [PATCH 3/3] mac80211: fix VLAN handling with TXQs Johannes Berg
2017-08-21 13:32 ` Toke Høiland-Jørgensen
2017-09-04 9:33 ` Johannes Berg
2017-09-04 14:23 ` Toke Høiland-Jørgensen
2017-09-05 6:58 ` Johannes Berg
2017-09-05 9:02 ` Toke Høiland-Jørgensen
2017-09-05 9:18 ` Johannes Berg
2017-09-05 9:49 ` Toke Høiland-Jørgensen [this message]
2017-09-05 9:54 ` Johannes Berg
2017-09-05 10:16 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zia91nmc.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).