From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:36327 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdIEJtf (ORCPT ); Tue, 5 Sep 2017 05:49:35 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , linux-wireless@vger.kernel.org Cc: nbd@nbd.name Subject: Re: [PATCH 3/3] mac80211: fix VLAN handling with TXQs In-Reply-To: <1504603125.12380.7.camel@sipsolutions.net> References: <20170622102030.9795-1-johannes@sipsolutions.net> <20170622102030.9795-3-johannes@sipsolutions.net> <87378lvyfz.fsf@toke.dk> <1504517620.9797.3.camel@sipsolutions.net> <87mv6a35lb.fsf@toke.dk> <1504594708.6667.1.camel@sipsolutions.net> <8760cx34cm.fsf@toke.dk> <1504603125.12380.7.camel@sipsolutions.net> Date: Tue, 05 Sep 2017 11:49:31 +0200 Message-ID: <87zia91nmc.fsf@toke.dk> (sfid-20170905_114938_533186_A59FC10B) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > On Tue, 2017-09-05 at 11:02 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>=20 >> > I'm not sure. However, I think it's less bad than one might guess >> > since it really should only affect multicast frames, right? All >> > unicast frames should go directly to the per-STA TXQ. >>=20 >> Ah, right, that is the interface txq that is being purged. Gotcha. >>=20 >> But, erm, what happens with unicast traffic sent on the VLAN >> interface when it goes down? Shouldn't that be purged from the per- >> station TXQs as well? > > Well, those entire TXQs are destroyed with the station :) Ah, so the station is attached to the VLAN interface, not the parent interface? I guess that the only case where there is likely to be any significant effects of dropping the whole queue is if someone is sending large amounts of multicast traffic (live video streaming? is that even feasible over WiFi?) while reconfiguring their VLAN setup. That is probably not a terribly common combination... -Toke