From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "michal.kazior@tieto.com" <michal.kazior@tieto.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"nbd@nbd.name" <nbd@nbd.name>
Subject: Re: [RFC] ath10k: silence firmware file probing warnings
Date: Tue, 2 Aug 2016 11:18:15 +0000 [thread overview]
Message-ID: <87ziov772h.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1468933237-5226-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Tue, 19 Jul 2016 15:00:37 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Firmware files are versioned to prevent older
> driver instances to load unsupported firmware
> blobs. This is reflected with a fallback logic
> which attempts to load several firmware files.
>
> This however produced a lot of unnecessary
> warnings sometimes confusing users and leading
> them to rename firmware files making things even
> more confusing.
>
> Hence use request_firmware_direct() which does not
> produce extra warnings. This shouldn't really
> break anything because most modern systems don't
> rely on udev/hotplug helpers to load firmware
> files anymore.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Nice. These "firmware not found" messages have been confusing ath10k
users for ages and should be properly fixed. I hope we find a solution.
But I talked with Felix about this and he made a good point about board
and calibration files. Calibration files might be created runtime, for
example retrieved from NAND etc, and this might break the use case when
ath10k is statically linked to kernel. Is the combination used in real
life and should we care, that I do not know, but I'm worried of possible
regressions. I guess LEDE/openwrt always loads ath10k as a module and
after the calibration file is created?
--
Kalle Valo
next prev parent reply other threads:[~2016-08-02 11:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 13:00 [RFC] ath10k: silence firmware file probing warnings Michal Kazior
2016-07-21 7:09 ` Stanislaw Gruszka
2016-07-21 7:36 ` Emmanuel Grumbach
2016-07-21 8:05 ` Stanislaw Gruszka
2016-07-21 10:23 ` Prarit Bhargava
2016-07-21 11:51 ` Stanislaw Gruszka
2016-07-21 12:01 ` Prarit Bhargava
2016-07-22 8:38 ` Arend Van Spriel
2016-07-22 10:26 ` Stanislaw Gruszka
2016-07-22 12:21 ` Arend Van Spriel
2016-07-22 12:51 ` Prarit Bhargava
2016-07-22 22:19 ` Luis R. Rodriguez
2016-07-25 7:51 ` Emmanuel Grumbach
2016-07-22 22:15 ` Luis R. Rodriguez
2016-07-28 19:23 ` Arend van Spriel
2016-08-02 11:10 ` Valo, Kalle
2016-08-02 14:16 ` Luis R. Rodriguez
2016-08-03 11:33 ` Arend van Spriel
2016-08-03 14:21 ` Luis R. Rodriguez
2016-08-03 15:04 ` Valo, Kalle
2016-08-03 17:10 ` Luis R. Rodriguez
2016-08-03 19:19 ` Arend van Spriel
2016-07-22 22:05 ` Luis R. Rodriguez
2016-07-28 19:23 ` Arend van Spriel
2016-07-28 23:28 ` Luis R. Rodriguez
2016-08-02 11:18 ` Valo, Kalle [this message]
2016-08-02 11:24 ` Felix Fietkau
2017-01-20 12:51 ` Kalle Valo
2017-01-20 12:56 ` Michal Kazior
2017-01-31 15:02 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziov772h.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).