From: Kalle Valo <kvalo@codeaurora.org>
To: Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <wil6210@qca.qualcomm.com>
Subject: Re: [PATCH 5/5] wil6210: update FW file name
Date: Mon, 30 Mar 2015 17:28:31 +0300 [thread overview]
Message-ID: <87zj6u36gg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <16442708.jC9XbHNgDJ@lx-wigig-72> (Vladimir Kondratiev's message of "Mon, 30 Mar 2015 17:00:00 +0300")
Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes:
> On Monday, March 30, 2015 12:38:08 PM Kalle Valo wrote:
>> Vladimir Kondratiev <QCA_vkondrat@QCA.qualcomm.com> writes:
>>
>> > Firmware "board" file name has changed from wil6210.board
>> > to wil6210.brd by the FW generation tools.
>> >
>> > Reflect this in the driver.
>> >
>
>> > -#define WIL_FW2_NAME "wil6210.board" /* board & radio parameters */
>> > +#define WIL_FW2_NAME "wil6210.brd" /* board & radio parameters */
>>
>> I consider the firmware file names as part of stable user space
>> interface (older user space need to work with newer kernel etc) and this
>> change breaks that.
>
> Hardware was not released to the public yet; no one besides developers
> in the lab should be affected by this.
Actually that doesn't matter as it's common to run few years old
kernels, especially in the embedded world. So no matter what, this
breaks compatibility with user space and without any real benefit
whatsoever. Now will anyone hit this in practise I don't know.
I guess this change is ok for now as wil6210 hw is not that common, but
in the future please be careful with this.
--
Kalle Valo
prev parent reply other threads:[~2015-03-30 14:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 8:28 [PATCH 0/5] wil6210 patches Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 1/5] wil6210: fw debug mode Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 2/5] wil6210: debug [add|del]_key operations Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 3/5] wil6210: trace disconnect source Vladimir Kondratiev
2015-03-30 8:28 ` [PATCH 4/5] wil6210: stop_ap to leave interface closed Vladimir Kondratiev
2015-03-30 8:45 ` Johannes Berg
2015-03-30 13:56 ` Vladimir Kondratiev
2015-04-07 16:30 ` Kalle Valo
2015-04-07 19:52 ` Johannes Berg
2015-04-08 8:06 ` Kalle Valo
2015-03-30 8:28 ` [PATCH 5/5] wil6210: update FW file name Vladimir Kondratiev
2015-03-30 9:38 ` Kalle Valo
2015-03-30 14:00 ` Vladimir Kondratiev
2015-03-30 14:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj6u36gg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=QCA_vkondrat@QCA.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).