* [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS
@ 2014-09-04 12:51 Matteo Croce
2014-09-10 11:23 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Matteo Croce @ 2014-09-04 12:51 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Matteo Croce
ATH10K_DEBUGFS must depend on DEBUG_FS, otherwise
ath10k will generate an invalid pointer on module load
Signed-off-by: Matteo Croce <matteo@openwrt.org>
---
drivers/net/wireless/ath/ath10k/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig
index 1053bb5..72acb82 100644
--- a/drivers/net/wireless/ath/ath10k/Kconfig
+++ b/drivers/net/wireless/ath/ath10k/Kconfig
@@ -24,7 +24,7 @@ config ATH10K_DEBUG
config ATH10K_DEBUGFS
bool "Atheros ath10k debugfs support"
- depends on ATH10K
+ depends on ATH10K && DEBUG_FS
select RELAY
---help---
Enabled debugfs support
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS
@ 2014-09-04 8:50 Matteo Croce
2014-09-04 10:04 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Matteo Croce @ 2014-09-04 8:50 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless
enable ath10k debugfs only when debugfs is enabled,
fixes an invalid pointer on module insert
--- a/drivers/net/wireless/ath/ath10k/Kconfig
+++ b/drivers/net/wireless/ath/ath10k/Kconfig
@@ -24,7 +24,7 @@ config ATH10K_DEBUG
config ATH10K_DEBUGFS
bool "Atheros ath10k debugfs support"
- depends on ATH10K
+ depends on ATH10K && DEBUG_FS
select RELAY
---help---
Enabled debugfs support
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS
2014-09-04 8:50 Matteo Croce
@ 2014-09-04 10:04 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2014-09-04 10:04 UTC (permalink / raw)
To: Matteo Croce; +Cc: ath10k, linux-wireless
Matteo Croce <matteo@openwrt.org> writes:
> enable ath10k debugfs only when debugfs is enabled,
> fixes an invalid pointer on module insert
>
> --- a/drivers/net/wireless/ath/ath10k/Kconfig
> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
This is missing Signed-off-by, so I cannot take this. Please check
Documentation/SubmittingPatches and please resend.
The safest way to submit a patch is to commit with 'git commit -s' and
then submit the commit with 'git send-email'. But first do a trial run
by submitting it to yourself.
--
Kalle Valo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-10 11:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-04 12:51 [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS Matteo Croce
2014-09-10 11:23 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2014-09-04 8:50 Matteo Croce
2014-09-04 10:04 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).