From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix num_sends_allowed replenishing
Date: Fri, 20 Sep 2013 08:06:50 +0300 [thread overview]
Message-ID: <87zjr8gjyt.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <1379510537-8731-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 18 Sep 2013 15:22:17 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> Recent ce_sendlist removal patch has broken
> num_sends_allowed incrementing. num_sends_allowed
> exceeded initial values and could overflow.
>
> This code was supposed to replenish
> num_sends_allowed for partial sendlist items (i.e.
> before final sendlist item from a sendlist was
> completed and could be processed by completion
> handlers).
>
> Fortunately it seems it cause any major breakage,
> yet.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Doh, I broke this. Sorry about that.
Applied, but I changed the commit log. Especially notice the changes in
the last sentence:
commit 1073ab2e9b0d45f318052a3f3690405fc04eda75
Author: Michal Kazior <michal.kazior@tieto.com>
Date: Wed Sep 18 15:22:17 2013 +0200
ath10k: fix num_sends_allowed replenishing
Commit e9bb0aa39 ("ath10k: delete struct ce_sendlist") broke
num_sends_allowed incrementing. num_sends_allowed
exceeded initial values and could overflow.
This code was supposed to replenish
num_sends_allowed for partial sendlist items (i.e.
before final sendlist item from a sendlist was
completed and could be processed by completion
handlers).
Fortunately it seems it did not cause any major breakage,
yet.
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
--
Kalle Valo
prev parent reply other threads:[~2013-09-20 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 13:22 [PATCH] ath10k: fix num_sends_allowed replenishing Michal Kazior
2013-09-20 5:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjr8gjyt.fsf@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox