From: Kalle Valo <kalle.valo@iki.fi>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-wireless@vger.kernel.org, Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH 1/4] wl1251: make local symbols static
Date: Fri, 12 Mar 2010 08:32:40 +0200 [thread overview]
Message-ID: <87zl2ecanr.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1268322276-16640-1-git-send-email-notasas@gmail.com> (Grazvydas Ignotas's message of "Thu\, 11 Mar 2010 17\:44\:36 +0200")
Grazvydas Ignotas <notasas@gmail.com> writes:
> Make local functions and data static, also constify
> some structures. While at it, clean up unneeded includes.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> Cc: Bob Copeland <me@bobcopeland.com>
Thanks. Looks good, but...
> -#include <linux/mod_devicetable.h>
...this is needed for struct sdio_device_id AFAICS. If you can send a
new version which keeps that include, you'll have my acked-by.
--
Kalle Valo
next prev parent reply other threads:[~2010-03-12 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 15:44 [PATCH 1/4] wl1251: make local symbols static Grazvydas Ignotas
2010-03-12 6:32 ` Kalle Valo [this message]
2010-03-12 10:02 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zl2ecanr.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).