From: Kalle Valo <kalle.valo@iki.fi>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, stable@kernel.org
Subject: Re: [PATCH 2/6 2.6.31 and w-t] iwlwifi: only show active power level via sysfs
Date: Thu, 09 Jul 2009 22:49:35 +0300 [thread overview]
Message-ID: <87zlbdprg0.fsf@litku.valot.fi> (raw)
In-Reply-To: <1247160821-14989-3-git-send-email-reinette.chatre@intel.com> (Reinette Chatre's message of "Thu\, 9 Jul 2009 10\:33\:37 -0700")
Reinette Chatre <reinette.chatre@intel.com> writes:
> From: Reinette Chatre <reinette.chatre@intel.com>
>
> This changes the power_level file to adhere to the "one value
> per file" sysfs rule. The user will know which power level was
> requested as it will be the number just written to this file. It
> is thus not necessary to create a new sysfs file for this value.
>
> In addition it fixes a problem where powertop's parsing expects
> this value to be the first value in this file without any descriptions.
In the future we need to drop all the driver private interfaces and use
nl80211/wext instead[1]. As this patch shows, they just create problems
for us. I recommend deprecating the file in question as soon as possible
and instead start using proper interfaces.
[1] Even though nl80211 is lacking power save support, but that will be
fixed soon. Use wext for now.
--
Kalle Valo
prev parent reply other threads:[~2009-07-09 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 17:33 [PATCH 0/6] iwlwifi driver updates 07/09/2009 Reinette Chatre
2009-07-09 17:33 ` [PATCH 1/6] iwlwifi: move show_qos to debugfs Reinette Chatre
2009-07-09 17:33 ` [PATCH 2/6 2.6.31 and w-t] iwlwifi: only show active power level via sysfs Reinette Chatre
2009-07-09 17:33 ` [PATCH 3/6] iwlwifi: fix permissions on debugfs files Reinette Chatre
2009-07-09 17:33 ` [PATCH 4/6 2.6.31 and w-t] iwlwifi: only update byte count table during aggregation Reinette Chatre
2009-07-09 17:33 ` [PATCH 5/6] iwl3945: cleanup number of queues settings Reinette Chatre
2009-07-09 17:33 ` [PATCH 6/6] iwlagn: fix minimum number of queues setting Reinette Chatre
2009-07-09 19:49 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zlbdprg0.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox