Re: [RFC 2/2] mac80211: implement dynamic power save

[Kalle Valo <kalle.valo@nokia.com>]

Luis R. Rodriguez <lrodriguez@atheros.com> writes:

> On Sun, Nov 09, 2008 at 07:43:59AM -0800, Kalle Valo wrote:
>> +++ b/net/mac80211/ieee80211_i.h
>> @@ -973,6 +978,10 @@ int ieee80211_set_freq(struct ieee80211_sub_if_data *sdata, int freq);
>>  u64 ieee80211_mandatory_rates(struct ieee80211_local *local,
>>                               enum ieee80211_band band);
>> 
>> +void ieee80211_ps_enable_work(struct work_struct *work);
>> +void ieee80211_ps_disable_work(struct work_struct *work);
>
> Should these also be prefixed with _dynamic ? May confuse other people
> working on regular ps mode I think.

I think we should. Actually there are three types of power save now:
AP mode buffering for clients in power save, the normal ("static")
power save for client mode and the dynamic version. So this will get
very confusing.

> Also can you elaborate a bit in the patch/log as to what dynamic power save
> concept is, what drivers who implement it are expected to do as well?

I will do that in the next round.

While talking about power save, can you give me any hints how power
save in client mode works in ath5k/ath9k? I haven't looked at the
drivers yet, but any hints (even how small) always help and save time.
I'm trying to understand how power save is implemented in different
hardware so that I can take that into account in my patches.

-- 
Kalle Valo