From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Kalle Valo <kvalo@codeaurora.org>,
<linux-wireless@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: <netdev@vger.kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/
Date: Wed, 30 Jan 2019 15:25:42 +0000 (UTC) [thread overview]
Message-ID: <883460220.650537.1548861942189@mail.yahoo.com> (raw)
In-Reply-To: 883460220.650537.1548861942189.ref@mail.yahoo.com
--------------------------------------------
On Fri, 25/1/19, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Currently, the Kbuild core manipulates header
> search paths in a crazy
> way [1].
> To fix this mess, I want all Makefiles
> to add explicit $(srctree)/ to
> the search paths in the srctree. Some
> Makefiles are already written in
> that way, but not all. The goal of this
> work is to make the notation
> consistent, and finally get rid of the
> gross hacks.
> Having whitespaces after -I does not
> matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without
> parameter").
> I also removed one header search path
> in:
> drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile
> I was able to compile without it.
> [1]: https://patchwork.kernel.org/patch/9632347/
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
Looks okay for the rtl818x parts.
next parent reply other threads:[~2019-01-30 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <883460220.650537.1548861942189.ref@mail.yahoo.com>
2019-01-30 15:25 ` Hin-Tak Leung [this message]
2019-01-25 15:18 [PATCH] net: wireless: prefix header search paths with $(srctree)/ Masahiro Yamada
2019-01-28 8:21 ` Kalle Valo
2019-01-28 8:26 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883460220.650537.1548861942189@mail.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox