From: Ping-Ke Shih <pkshih@realtek.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Zenm Chen <zenmchen@gmail.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>
Cc: "Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH][next] wifi: rtl8xxxu: Avoid -Wflex-array-member-not-at-end warnings
Date: Fri, 21 Nov 2025 11:12:40 +0000 [thread overview]
Message-ID: <884145e57dc640d3bed29922d352f658@realtek.com> (raw)
In-Reply-To: <ff184c0e-17f2-445f-9339-f4db9943db86@embeddedor.com>
Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> On 11/21/25 19:06, Zenm Chen wrote:
> > Dear maintainers,
> >
> > With this patch applied, my system always freezes right after the rtl8xxxu
> > driver is loaded. is it normal?
>
> I don't think so... It probably means that struct urb urb; cannot really be
> moved to the end of struct rtl8xxxu_rx_urb or struct rtl8xxxu_tx_urb?
>
> It'd be great if you could share a log.
>
> Thanks for the report!
> -Gustavo
>
> >
> > OS: Arch Linux
> > kernel: 6.17.8-arch1-1
> > test devices: RTL8192{CU,EU,FU}
> >
As my review, 'struct urb urb;' seems only a member data.
No order problem.
To have enough time to dig the problem, I'd drop this patch
from my pull-request for now.
prev parent reply other threads:[~2025-11-21 11:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 9:08 [PATCH][next] wifi: rtl8xxxu: Avoid -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-11-21 6:09 ` Ping-Ke Shih
2025-11-21 10:06 ` Zenm Chen
2025-11-21 10:19 ` Gustavo A. R. Silva
2025-11-21 11:11 ` Zenm Chen
2025-11-23 20:29 ` Bitterblue Smith
2025-11-24 6:37 ` Ping-Ke Shih
2025-11-24 8:02 ` Zenm Chen
2025-11-26 3:26 ` Ping-Ke Shih
2025-12-06 21:53 ` Bitterblue Smith
2025-12-06 23:16 ` Michal Pecio
2025-12-06 23:55 ` Greg KH
2025-12-07 8:05 ` Michal Pecio
2025-12-08 0:05 ` Bitterblue Smith
2025-11-21 11:12 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=884145e57dc640d3bed29922d352f658@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=zenmchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).