From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E83C06510 for ; Tue, 2 Jul 2019 09:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87A7D206A2 for ; Tue, 2 Jul 2019 09:51:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="azgcgMui" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727241AbfGBJv4 (ORCPT ); Tue, 2 Jul 2019 05:51:56 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53930 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727089AbfGBJvu (ORCPT ); Tue, 2 Jul 2019 05:51:50 -0400 Received: by mail-wm1-f66.google.com with SMTP id x15so210989wmj.3 for ; Tue, 02 Jul 2019 02:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZbbPe/OgCkiI4UCDPbrGqbpRXXo3jc53/IKcexuq+WY=; b=azgcgMuiRaVzBsgq1sukrVxzQ8OQuO+/ImiTQZlIiE7yGz03+rGbwf/y+jlTa8EVf5 U5BPvszqu9eAKAv0ehLi3h1SuJNp0vPwtFnYTKvaQ++xEClDFTHjrCEC2Yj+9hhdbWY/ GwyYqY4lC+isc3OF9NDiW3EhrcB+/X0mWegpk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZbbPe/OgCkiI4UCDPbrGqbpRXXo3jc53/IKcexuq+WY=; b=A7cSWjbto9zDIImq7abUEUCab3rvXmuRkl8PPChyBUgeZR2ndgxOr8+VoWfYjWCgFa iXMZ7uHaYFXhBRm9wt9wcB+EgFKsz6mnfEpFll7JNq0OLLCQyYxh5i77Fxdc5j6edMSp Jz45TLYHvYpy3SXWE1gGgyMcLSssy6qua0bZpGqp8UcPkgIqa9mrWlLJVsvcCqqBbOSY J9acJce8WgNKo4RV+A91C29yfHY4vCCNr4xh1Iee3jZEQ61CeR4+na48LwDzxVP3z4EX FnEiHrNpoEp32JuiwOZ/rti8vXuw8hhyN0TwZ0TZaTWOcwlEd0Jnqfu4owT+YihQbj7M m7ew== X-Gm-Message-State: APjAAAWAsUB06t51RRViGIqwtR2jt20ectAxEE1Y8jehfe2RqFDHQlzk OwBspQKgar0FXSUp15vx22Mp+g== X-Google-Smtp-Source: APXvYqxfIT/N6efY+/XizNeh8qrIpeIdC2hZSqzcbMa/pkJ8u1aYFYMrVYqI5zI2V3ar9yLnF7yjWg== X-Received: by 2002:a1c:7d4e:: with SMTP id y75mr2855969wmc.169.1562061108255; Tue, 02 Jul 2019 02:51:48 -0700 (PDT) Received: from [10.176.68.244] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id g25sm1479624wmk.39.2019.07.02.02.51.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jul 2019 02:51:47 -0700 (PDT) Subject: Re: [PATCH] brcmfmac: Replace two seq_printf() calls in brcmf_feat_fwcap_debugfs_read() To: Markus Elfring , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list@cypress.com, brcm80211-dev-list.pdl@broadcom.com, Chi-Hsien Lin , "David S. Miller" , Franky Lin , Hante Meuleman , Kalle Valo , Pieter-Paul Giesberts , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Wright Feng Cc: LKML , kernel-janitors@vger.kernel.org References: <7d96085a-76e8-c290-698a-e1473d3f4be7@web.de> From: Arend Van Spriel Message-ID: <893cc567-0126-3ab9-92c5-de430fb066fc@broadcom.com> Date: Tue, 2 Jul 2019 11:51:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <7d96085a-76e8-c290-698a-e1473d3f4be7@web.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 7/2/2019 11:50 AM, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 2 Jul 2019 11:31:07 +0200 > > A line break and a single string should be put into a sequence. > Thus use the corresponding output functions. > > This issue was detected by using the Coccinelle software. pot-ato, po-tato > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c > index 73aff4e4039d..ec0e80296e43 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c > @@ -225,10 +225,10 @@ static int brcmf_feat_fwcap_debugfs_read(struct seq_file *seq, void *data) > } > > /* Usually there is a space at the end of capabilities string */ > - seq_printf(seq, "%s", caps); > + seq_puts(seq, caps); > /* So make sure we don't print two line breaks */ > if (tmp > caps && *(tmp - 1) != '\n') > - seq_printf(seq, "\n"); > + seq_putc(seq, '\n'); > > return 0; > } > -- > 2.22.0 >