From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>,
Christian Hewitt <chewitt@libreelec.tv>
Subject: RE: [PATCH v7 5/6] wifi: rtlwifi: Clean up rtl8192d-common a bit
Date: Fri, 26 Apr 2024 01:58:59 +0000 [thread overview]
Message-ID: <89595f7d899f48dbb3a6832fca085935@realtek.com> (raw)
In-Reply-To: <f6acfa78-2f4e-47f1-95d4-65aa77510113@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>
> Improve readability:
> * add empty lines
> * use abs_diff in rtl92d_dm_txpower_tracking_callback_thermalmeter
> * roll up repeated statements into a for loop in
> rtl92d_dm_txpower_tracking_callback_thermalmeter
> * shorten lines by replacing many instances of "rtlpriv->dm" with "dm"
> pointer in rtl92d_dm_txpower_tracking_callback_thermalmeter
> * sort some declarations by length
> * refactor _rtl92d_get_txpower_writeval_by_regulatory a little
> * refactor _rtl92de_readpowervalue_fromprom a little
>
> Delete unused structs tag_dynamic_init_gain_operation_type_definition
> and swat.
>
> Simplify rtl92d_fill_h2c_cmd a little and delete a pointless wrapper
> function.
>
> Tested with a single MAC single PHY USB dongle from Aliexpress labelled
> "CC&C WL-6210-V3".
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thanks for the cosmetics of this patch. It looks much better. :)
next prev parent reply other threads:[~2024-04-26 1:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:08 [PATCH v7 0/6] wifi: rtlwifi: Move common code from rtl8192de to rtl8192d-common Bitterblue Smith
2024-04-25 18:09 ` [PATCH v7 1/6] wifi: rtlwifi: rtl8192de: Fix 5 GHz TX power Bitterblue Smith
2024-05-02 2:55 ` Ping-Ke Shih
2024-04-25 18:12 ` [PATCH v7 2/6] wifi: rtlwifi: rtl8192de: Fix low speed with WPA3-SAE Bitterblue Smith
2024-04-25 18:13 ` [PATCH v7 3/6] wifi: rtlwifi: rtl8192de: Fix endianness issue in RX path Bitterblue Smith
2024-04-25 18:14 ` [PATCH v7 4/6] wifi: rtlwifi: Move code from rtl8192de to rtl8192d-common Bitterblue Smith
2024-04-25 18:14 ` [PATCH v7 5/6] wifi: rtlwifi: Clean up rtl8192d-common a bit Bitterblue Smith
2024-04-26 1:58 ` Ping-Ke Shih [this message]
2024-04-25 18:15 ` [PATCH v7 6/6] wifi: rtlwifi: Adjust rtl8192d-common for USB Bitterblue Smith
2024-04-26 2:09 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89595f7d899f48dbb3a6832fca085935@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chewitt@libreelec.tv \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
--cc=s.l-h@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).