Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Manoharan, Rajkumar" <rmanohar@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: RE: mac80211 20/40 coexist
Date: Thu, 15 Mar 2012 20:49:39 +0000	[thread overview]
Message-ID: <8F3AF1C9F856774F8C8D67AA7EDFEC8801E3005E@aphydexd01b> (raw)
In-Reply-To: <1331818214.3432.12.camel@jlt3.sipsolutions.net>


> The commit "mac80211: stop tx before doing hw config and rate
> update" (and a later commit fixing it) introduced a queue stop & flush
> on switching 20/40.
>
> I'm working on not calling hw_config() for switching between 20/40 but
> instead only calling rate_control_rate_update() and
> ieee80211_bss_info_change_notify() to tell the rate control and driver.

Johannes,

Not calling hw_config could affect drivers like ath9k_htc where the rate control runs in the firmware.
Those drivers will update the rate control based on CHANGED_HT flag.

>
> If we do that, is it still necessary to stop the queues for it? It seems
> like it shouldn't.

Actually the queue stop was added to avoid mismatches b/w hw and rate control. But If you dont stop the queues
before the rate control change, the station might send the frames in different ht mode (for example ht40) wrt AP's ht mode (ht20).

-Rajkumar

  reply	other threads:[~2012-03-15 20:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15 13:30 mac80211 20/40 coexist Johannes Berg
2012-03-15 20:49 ` Manoharan, Rajkumar [this message]
2012-03-16 13:01   ` Johannes Berg
2012-03-16 13:46     ` Johannes Berg
2012-03-16 18:39     ` Manoharan, Rajkumar
2012-03-18 10:19       ` Johannes Berg
2012-03-18 19:19         ` Adrian Chadd
2012-03-19  3:49           ` Sujith Manoharan
2012-03-19  4:49             ` Adrian Chadd
2012-03-19  4:59               ` Sujith Manoharan
2012-03-19  8:26             ` Johannes Berg
2012-03-19 10:08               ` Sujith Manoharan
2012-03-19 10:13                 ` Johannes Berg
2012-03-19  8:24           ` Johannes Berg
2012-03-19  2:55         ` Sujith Manoharan
2012-03-19  8:23           ` Johannes Berg
2012-03-19 10:04             ` Sujith Manoharan
2012-03-19 10:09               ` Johannes Berg
2012-03-19 10:32                 ` Sujith Manoharan
2012-03-19 11:12                   ` Johannes Berg
2012-03-19 12:18                     ` Johannes Berg
2012-03-20  4:39                       ` Sujith Manoharan
2012-03-20 11:32                         ` Johannes Berg
2012-03-20 15:26                           ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8F3AF1C9F856774F8C8D67AA7EDFEC8801E3005E@aphydexd01b \
    --to=rmanohar@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox