Re: [PATCH 2/6] wifi: rtw88: 88xxa: receive VHT SU beamformed transmissions

[Bitterblue Smith <rtl8821cerfe2@gmail.com>]

On 29/10/2026 16:13, Ho Jie Feng wrote:
> On 29/10/2026 14:33, Bitterblue Smith wrote:
>> On 29/10/2026 07:52, Ho Jie Feng wrote:
>>> Implement beamformee support for 88xxa since they have
>>> support for it.
>>>
>>> Signed-off-by: Ho Jie Feng <hjf3108@gmail.com>
>>> ---
>>>  drivers/net/wireless/realtek/rtw88/bf.h       |  2 +
>>>  drivers/net/wireless/realtek/rtw88/main.c     | 12 ++--
>>>  drivers/net/wireless/realtek/rtw88/reg.h      |  1 +
>>>  drivers/net/wireless/realtek/rtw88/rtw8812a.c |  3 +-
>>>  drivers/net/wireless/realtek/rtw88/rtw8814a.c | 36 ++++++++++-
>>>  drivers/net/wireless/realtek/rtw88/rtw8821a.c |  3 +-
>>>  drivers/net/wireless/realtek/rtw88/rtw88xxa.c | 62 +++++++++++++++++++
>>>  drivers/net/wireless/realtek/rtw88/rtw88xxa.h |  2 +
>>>  8 files changed, 112 insertions(+), 9 deletions(-)
>>>
>>
>> Is it really this simple? The vendor driver has a lot more
>> beamforming code than this.
> 
> Yes, this is the beamformee code, not the beamformer,
> which has way more code than this. The RTL8812AU is acting as
> the target for the AP to beamform to for this one.
> 

Oh, I see. I didn't look very closely at the vendor code.

> I have the beamformer code, which the RTL8812AU
> beamforms, but I dropped it since it reduces throughput.
> 
> I can put the patch out if you wish to see it, but
> won't be enabling for 88xxa.
> 
> Reference:
> https://github.com/aircrack-ng/rtl8812au/blob/v5.6.4.2/hal/phydm/txbf/haltxbfjaguar.c#L229
> 

By the way, there is a newer version:
https://github.com/morrownr/8812au-20210820

I don't know if there are any differences in the beamforming code.

> Vendor driver and rtw88 can be sometimes confusing for
> the bfee vs bfer distinction.
> 
>>> ...
>>>  	if (rtwdev->hal.rf_path_num > 1)
>>>  		vht_cap->cap |= IEEE80211_VHT_CAP_TXSTBC;
>>> -	vht_cap->cap |= IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE |
>>> -			IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE;
>>> -	vht_cap->cap |= (rtwdev->hal.bfee_sts_cap <<
>>> -			IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT);
>>> +	if (rtw_bf_support && chip->bfer_su_max_num) {
>>> +		vht_cap->cap |= IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE;
>>> +		vht_cap->cap |= rtwdev->hal.bfee_sts_cap <<
>>> +				IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT;
>>> +	}
>>> +	if (rtw_bf_support && chip->bfer_mu_max_num)
>>> +		vht_cap->cap |= IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE;
>>>  
>>>  	if (rtw_chip_has_rx_ldpc(rtwdev))
>>>  		vht_cap->cap |= IEEE80211_VHT_CAP_RXLDPC;
>>
>> This could be a separate patch, since it doesn't look related to 88xxa.
> 
> I can put this in v2.
> 
>>> ...