From: Johannes Berg <johannes@sipsolutions.net>
To: John Crispin <john@phrozen.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
Srini Kode <skode@qti.qualcomm.com>,
Shashidhar Lakkavalli <slakkavalli@datto.com>,
ath11k@lists.infradead.org
Subject: Re: [PATCH V2 1/3] mac80211: allow turning TWT responder support on and off via netlink
Date: Fri, 26 Apr 2019 21:51:26 +0200 [thread overview]
Message-ID: <8b456918fc5cd0674f834771be2bb5134bccd26a.camel@sipsolutions.net> (raw)
In-Reply-To: <2f153f21-17fe-26aa-98a4-b82cdb16ffff@phrozen.org>
On Fri, 2019-04-26 at 21:50 +0200, John Crispin wrote:
> On 26/04/2019 11:41, John Crispin wrote:
> > @@ -6105,6 +6106,7 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
> > params.ht_opmode = -1;
> > params.p2p_ctwindow = -1;
> > params.p2p_opp_ps = -1;
> > + params.twt_responder = -1;
> >
> > if (info->attrs[NL80211_ATTR_BSS_CTS_PROT])
> > params.use_cts_prot =
> > @@ -6149,6 +6151,10 @@ static int nl80211_set_bss(struct sk_buff *skb, struct genl_info *info)
> > return -EINVAL;
> > }
> >
> > + if (info->attrs[NL80211_ATTR_TWT_RESPONDER])
> > + params.twt_responder =
> > + nla_get_u8(info->attrs[NL80211_ATTR_TWT_RESPONDER]);
> > +
> > if (!rdev->ops->change_bss)
> > return -EOPNOTSUPP;
>
> Hi,
>
> this should probably be moved to nl80211_start_ap() instead of
> nl80211_set_bss() as we probably dont want to change this at runtime ?
I have no idea, can we change it at runtime? Is it a capability or an
operational state?
johannes
next prev parent reply other threads:[~2019-04-26 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 9:41 [PATCH V2 0/3] mac80211: notify the driver when it should enable TWT John Crispin
2019-04-26 9:41 ` [PATCH V2 1/3] mac80211: allow turning TWT responder support on and off via netlink John Crispin
2019-04-26 19:50 ` John Crispin
2019-04-26 19:51 ` Johannes Berg [this message]
2019-04-26 19:53 ` John Crispin
2019-04-30 6:42 ` Rajkumar Manoharan
2019-04-26 9:41 ` [PATCH V2 2/3] mac80211: dynamically turn TWT requester support on and off John Crispin
2019-04-30 6:45 ` Rajkumar Manoharan
2019-04-30 6:58 ` John Crispin
2019-04-26 9:41 ` [PATCH V2 3/3] ath11k: add TWT support John Crispin
2019-04-30 6:50 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b456918fc5cd0674f834771be2bb5134bccd26a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
--cc=skode@qti.qualcomm.com \
--cc=slakkavalli@datto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).