From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 02/12] nl80211: add attributes for multiple bssid related settings
Date: Wed, 10 Jun 2020 21:24:00 -0700 [thread overview]
Message-ID: <8cc57539ad26d2cf49ef347cd65471ea@codeaurora.org> (raw)
In-Reply-To: <20200604070952.15481-3-john@phrozen.org>
On 2020-06-04 00:09, John Crispin wrote:
> When we start a multiple bssid AP we need to pass the index and number
> of
> peers aswell to the kernel. This info needs to be propagated to the
> driver.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
> include/net/cfg80211.h | 12 ++++++++++++
> include/uapi/linux/nl80211.h | 7 +++++++
> net/wireless/nl80211.c | 15 +++++++++++++++
> 3 files changed, 34 insertions(+)
>
[...]
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 3b502514944c..58ce67bc31da 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -667,6 +667,8 @@ const struct nla_policy
> nl80211_policy[NUM_NL80211_ATTR] = {
> NL80211_MULTIPLE_BSSID_LEGACY,
> NL80211_MULTIPLE_BSSID_NON_TRANSMITTED),
> [NL80211_ATTR_MULTI_BSSID_PARENT] = { .type = NLA_U32 },
> + [NL80211_ATTR_MULTI_BSSID_INDEX] = { .type = NLA_U32 },
> + [NL80211_ATTR_MULTI_BSSID_COUNT] = { .type = NLA_U32 },
> };
>
> /* policy for the key attributes */
> @@ -4996,6 +4998,11 @@ static int nl80211_start_ap(struct sk_buff
> *skb, struct genl_info *info)
> !info->attrs[NL80211_ATTR_BEACON_HEAD])
> return -EINVAL;
>
> + if (wdev->multi_bssid_mode == NL80211_MULTIPLE_BSSID_NON_TRANSMITTED
> &&
> + (!info->attrs[NL80211_ATTR_MULTI_BSSID_INDEX] ||
> + !info->attrs[NL80211_ATTR_MULTI_BSSID_COUNT]))
> + return -EINVAL;
> +
> err = nl80211_parse_beacon(rdev, info->attrs, ¶ms.beacon);
> if (err)
> return err;
> @@ -5150,6 +5157,14 @@ static int nl80211_start_ap(struct sk_buff
> *skb, struct genl_info *info)
> return err;
> }
>
> + if (info->attrs[NL80211_ATTR_MULTI_BSSID_INDEX])
> + params.multi_bssid.index = nla_get_u32(
> + info->attrs[NL80211_ATTR_MULTI_BSSID_INDEX]);
> +
> + if (info->attrs[NL80211_ATTR_MULTI_BSSID_COUNT])
> + params.multi_bssid.count = nla_get_u32(
> + info->attrs[NL80211_ATTR_MULTI_BSSID_COUNT]);
> +
John,
Does the count include transmitting and non-transmitting APs? Or just
child-node counts.
Are you expecting start_ap() for all non-trasmitting AP as well? Hope
this count can be
set only for parent AP?
-Rajkumar
next prev parent reply other threads:[~2020-06-11 4:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 7:09 [PATCH 00/12] mac80211: add multiple bssid support John Crispin
2020-06-04 7:09 ` [PATCH 01/12] nl80211: add basic " John Crispin
2020-06-10 0:25 ` Rajkumar Manoharan
2020-06-04 7:09 ` [PATCH 02/12] nl80211: add attributes for multiple bssid related settings John Crispin
2020-06-11 4:24 ` Rajkumar Manoharan [this message]
2020-06-04 7:09 ` [PATCH 03/12] nl80211: add attributes to set beacon transmit mode John Crispin
2020-06-04 7:09 ` [PATCH 04/12] mac80211: add multiple bssid support John Crispin
2020-06-04 7:09 ` [PATCH 05/12] mac80211: add multiple bssid IE parsing John Crispin
2020-06-04 7:09 ` [PATCH 06/12] mac80211: propagate multi bssid settings when starting an AP John Crispin
2020-06-04 7:09 ` [PATCH 07/12] mac80211: propagate beacon tx mode to the driver John Crispin
2020-06-04 7:09 ` [PATCH 08/12] ath11k: pass multiple bssid info to FW when a new vdev is created John Crispin
2020-06-04 7:09 ` [PATCH 09/12] ath11k: add a struct to pass parameters into ath11k_wmi_vdev_up John Crispin
2020-06-04 7:09 ` [PATCH 10/12] ath11k: add the multiple bssid IE offset to the beacon template John Crispin
2020-06-04 7:09 ` [PATCH 11/12] ath11k: set beacon tx mode John Crispin
2020-06-04 7:09 ` [PATCH 12/12] ath11k: set the multiple bssid hw cap John Crispin
2020-06-08 11:09 ` Kalle Valo
2020-06-08 11:29 ` John Crispin
2020-06-11 4:44 ` Rajkumar Manoharan
2020-06-09 3:35 ` [PATCH 00/12] mac80211: add multiple bssid support Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cc57539ad26d2cf49ef347cd65471ea@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).