Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Ömer Mete Kaya" <omermetekaya0@gmail.com>,
	linux-wireless@vger.kernel.org
Cc: kvalo@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,  horms@kernel.org,
	syzbot+adeb8550754921fece20@syzkaller.appspotmail.com,
	 syzbot+101224300649c3eb8af4@syzkaller.appspotmail.com,
	 syzbot+8141dcbd23a8f857798a@syzkaller.appspotmail.com,
	 syzbot+b0ae8f1abf7d891e0426@syzkaller.appspotmail.com,
	 syzbot+d6bbe0f5705cb8a5aa2b@syzkaller.appspotmail.com
Subject: Re: [PATCH] wifi: cfg80211: avoid holding rtnl_mutex across all cfg80211_leave() calls
Date: Sun, 06 Sep 2026 13:57:49 +0200	[thread overview]
Message-ID: <8e094e1bd016b04d3ab3bb02be2723aebaf9c9e4.camel@sipsolutions.net> (raw)
In-Reply-To: <20260906002657.620076-2-omermetekaya0@gmail.com> (sfid-20260906_022719_558651_B6EAD15C)

On Sun, 2026-09-06 at 03:25 +0300, Ömer Mete Kaya wrote:
> 
> +	/*
> +	 * Snapshot rdev pointers under RCU with a device reference so they
> +	 * cannot be freed between per-device rtnl acquisitions. Using a
> +	 * per-device rtnl_lock() instead of holding it across all devices
> +	 * avoids starving other rtnl waiters when cfg80211_leave() is slow.
> +	 */
> +	rcu_read_lock();
> +	list_for_each_entry_rcu(rdev, &cfg80211_rdev_list, list)
> +		n++;
> +	rcu_read_unlock();
>  
> -	rtnl_unlock();
> +	if (!n)
> +		return;
> +
> +	snap = kmalloc_array(n, sizeof(*snap), GFP_KERNEL);
> +	if (!snap)
> +		return;

I really don't know _what_ you're doing here, or more realistically what
exactly you're asking your LLM to do here, but it's pointless. Please
just stop, you're not helping in any way.

johannes

  reply	other threads:[~2026-09-06 11:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 11:13 [PATCH] wifi: cfg80211: avoid holding rtnl_mutex across all cfg80211_leave() calls Ömer Mete Kaya
2026-09-03 15:13 ` Ömer Mete Kaya
2026-09-03 15:13   ` [PATCH v2] " Ömer Mete Kaya
2026-09-05 18:45     ` Simon Horman
2026-09-06  0:25     ` Ömer Mete Kaya
2026-09-06  0:25       ` [PATCH] " Ömer Mete Kaya
2026-09-06 11:57         ` Johannes Berg [this message]
2026-09-07 16:38         ` Ben Greear
2026-09-08  8:58           ` Ömer Mete Kaya
2026-09-08 16:50             ` Ben Greear
2026-09-08 19:52               ` Ömer Mete Kaya
2026-09-08 20:09                 ` Ben Greear
2026-09-08 22:32                   ` Ömer Mete Kaya
2026-09-08 23:40                     ` Ben Greear
2026-09-09 17:54                       ` Ömer Mete Kaya
2026-09-09 15:26         ` netdev-bot+sashiko
  -- strict thread matches above, loose matches on Subject: below --
2026-09-03 15:05 Ömer Mete Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e094e1bd016b04d3ab3bb02be2723aebaf9c9e4.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=horms@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=omermetekaya0@gmail.com \
    --cc=syzbot+101224300649c3eb8af4@syzkaller.appspotmail.com \
    --cc=syzbot+8141dcbd23a8f857798a@syzkaller.appspotmail.com \
    --cc=syzbot+adeb8550754921fece20@syzkaller.appspotmail.com \
    --cc=syzbot+b0ae8f1abf7d891e0426@syzkaller.appspotmail.com \
    --cc=syzbot+d6bbe0f5705cb8a5aa2b@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox