From: Ping-Ke Shih <pkshih@realtek.com>
To: Ian Rogers <irogers@google.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
Elkin Cruz <elkin@google.com>
Subject: RE: [PATCH] wifi: rtlwifi: Fix octal 024 typo in P2P_PS_OFFLOAD H2C command IDs
Date: Fri, 20 Nov 2026 00:33:33 +0000 [thread overview]
Message-ID: <8e2a33ce03c74e14bd9f3f4a33833c7b@realtek.com> (raw)
In-Reply-To: <20261119170753.1526210-1-irogers@google.com>
Ian Rogers <irogers@google.com> wrote:
> In rtl8821ae, rtl8192ee, and rtl8188ee, the H2C power-save command enums
> define 0x20, 0x21, 0x22, 0x23 followed by 'H2C_*_P2P_PS_OFFLOAD = 024'.
> The missing 'x' makes 024 an octal constant (decimal 20, 0x14) instead of
> 0x24 (decimal 36, matching H2C_8723B_P2P_PS_OFFLOAD = 0x24 in rtl8723be
> and rtl8xxxu), sending the wrong H2C command ID to firmware during Wi-Fi
> Direct P2P power-save offload updates.
>
> Change 024 to 0x24 in all three headers.
>
> Found via inspection of H2C command enums during an x86_64 LLVM=1
> (Clang 21.1.8) allyesconfig warning audit; fix and changelog drafted with
> an AI coding assistant. Build-tested under LLVM=1 W=1 (-Werror); not
> tested on Realtek Wi-Fi hardware.
>
> Fixes: f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver")
> Fixes: 21e4b0726dc6 ("rtlwifi: rtl8821ae: Move driver from staging to regular tree")
> Fixes: b1a3bfc97cd9 ("rtlwifi: rtl8192ee: Move driver from staging to the regular tree")
> Signed-off-by: Ian Rogers <irogers@google.com>
Cross check with vendor driver. 0x24 is correct.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
prev parent reply other threads:[~2026-11-20 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:07 [PATCH] wifi: rtlwifi: Fix octal 024 typo in P2P_PS_OFFLOAD H2C command IDs Ian Rogers
2026-11-20 0:33 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e2a33ce03c74e14bd9f3f4a33833c7b@realtek.com \
--to=pkshih@realtek.com \
--cc=elkin@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox