Re: [RFC] mac80211: disable aggregatin for voice traffic

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 18 Nov 2010 17:18:54 -0800, "Luis R. Rodriguez"
<lrodriguez@atheros.com> wrote:
> This should help with latency issues which can happen when
> using aggregation.
> 
> Cc: Matt Smith <matt.smith@atheros.com>
> Cc: Senthil Balasubramanian <senthilkumar@atheros.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> 
> We discussed this a while ago but never to around to it.
> 
>  net/mac80211/tx.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index e694836..405ddc9 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -1225,7 +1225,8 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data
> *sdata,
>  		tx->sta = sta_info_get(sdata, hdr->addr1);
>  
>  	if (tx->sta && ieee80211_is_data_qos(hdr->frame_control) &&
> -	    (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION)) {
> +	    (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION) &&
> +	    (ieee802_1d_to_ac[skb->priority] != IEEE80211_AC_VO)) {

wtf? total NACK. You're setting up an aggregation session and then not
using it? That's totally deluded ... just don't set up the session!!

johannes