From: Vivek Natarajan <vivek.natraj@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix the wrong WARN_ON message appearing on enabling power save.
Date: Thu, 5 Feb 2009 17:56:13 +0530 [thread overview]
Message-ID: <8e92b4100902050426x5c6a0da5r86c3e6ca945b29c1@mail.gmail.com> (raw)
In-Reply-To: <1233835647.3931.13.camel@johannes.local>
On Thu, Feb 5, 2009 at 5:37 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2009-02-05 at 16:36 +0530, Vivek Natarajan wrote:
>> The warning message intended to be hit on driver's rejection of a Tx frame
>> is also hit while the netif_subqueue is stopped. This patch fixes this error
>> case.
>
> This seems a little odd. Why would we be in that code if the queue is
> stopped?
This issue happens only when we are associated with a 11n AP and power
save is enabled.
In the function 'ieee80211_master_start_xmit', ps_disable_work is
queued where wake_queues is called. But before this work is executed,
we check if the queues are stopped in _ieee80211_tx and returned
TX_AGAIN to ieee8011_tx which led to the warning message.
Vivek.
next prev parent reply other threads:[~2009-02-05 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 11:06 [PATCH] mac80211: Fix the wrong WARN_ON message appearing on enabling power save Vivek Natarajan
2009-02-05 12:07 ` Johannes Berg
2009-02-05 12:26 ` Vivek Natarajan [this message]
2009-02-05 13:35 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2009-02-05 14:35 Vivek Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e92b4100902050426x5c6a0da5r86c3e6ca945b29c1@mail.gmail.com \
--to=vivek.natraj@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox