Linux wireless drivers development
 help / color / mirror / Atom feed
From: Vivek Natarajan <vivek.natraj@gmail.com>
To: Kalle Valo <kalle.valo@iki.fi>
Cc: Vivek Natarajan <vnatarajan@atheros.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] mac80211: Send null data frame after disabling power save in Tx path.
Date: Wed, 25 Nov 2009 15:20:22 +0530	[thread overview]
Message-ID: <8e92b4100911250150p31f3d0dr6cdace01ff8c55a5@mail.gmail.com> (raw)
In-Reply-To: <87zl6b9f0i.fsf@purkki.valot.fi>

On Wed, Nov 25, 2009 at 2:07 PM, Kalle Valo <kalle.valo@iki.fi> wrote:
> Vivek Natarajan <vnatarajan@atheros.com> writes:
>
>> For drivers setting IEEE80211_HW_PS_NULLFUNC_STACK, a null data frame
>> with PM bit off has to be sent before sending normal data frames.
>
> Why? Sending a data frame with PM bit off should be enough to inform
> AP that the client is awake.

Since the subtype is different for null function data frame
(IEEE80211_STYPE_NULLFUNC)  which is normally used to indicate the
power management status , than normal data frame
(IEEE80211_STYPE_DATA), I thought some APs might create some
functionality issues by checking the frame subtype.
After your mail, I looked at the spec and it does not mention about
null frame in this context. It says,
'STAs changing Power Management mode shall inform the AP of this fact
using the Power Management bits within the Frame Control field of
transmitted frames. '

Accordingly, the present implementation might be correct. Thanks for
pointing it out.

Vivek.

  reply	other threads:[~2009-11-25  9:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25  7:05 [RFC PATCH] mac80211: Send null data frame after disabling power save in Tx path Vivek Natarajan
2009-11-25  8:37 ` Kalle Valo
2009-11-25  9:50   ` Vivek Natarajan [this message]
2009-11-25 10:21 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e92b4100911250150p31f3d0dr6cdace01ff8c55a5@mail.gmail.com \
    --to=vivek.natraj@gmail.com \
    --cc=kalle.valo@iki.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=vnatarajan@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox