From: Felix Fietkau <nbd@nbd.name>
To: Daniel Golle <daniel@makrotopia.org>,
linux-mediatek@lists.infradead.org,
linux-wireless@vger.kernel.org
Cc: Ryder Lee <ryder.lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH] mt76: eeprom: tolerate corrected bit-flips
Date: Thu, 25 Nov 2021 19:44:26 +0100 [thread overview]
Message-ID: <8ed35f3f-b0a2-dd93-e78c-33233bc6497a@nbd.name> (raw)
In-Reply-To: <YZ/XvfwzqUyjmBCm@makrotopia.org>
On 2021-11-25 19:36, Daniel Golle wrote:
> mtd_read() returns -EUCLEAN in case of corrected bit-flips.
> As data was read, don't error out in this case.
>
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c
> index 2d58aa31db934..0eb98f7ff7ec0 100644
> --- a/drivers/net/wireless/mediatek/mt76/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c
> @@ -65,7 +65,7 @@ int mt76_get_of_eeprom(struct mt76_dev *dev, void *eep, int offset, int len)
> offset = be32_to_cpup(list);
> ret = mtd_read(mtd, offset, len, &retlen, eep);
> put_mtd_device(mtd);
> - if (ret) {
> + if (ret && !mtd_is_bitflip(err)) {
I don't think this will even compile (err vs ret)
- Felix
next prev parent reply other threads:[~2021-11-25 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 18:36 [PATCH] mt76: eeprom: tolerate corrected bit-flips Daniel Golle
2021-11-25 18:44 ` Felix Fietkau [this message]
2021-11-25 19:43 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed35f3f-b0a2-dd93-e78c-33233bc6497a@nbd.name \
--to=nbd@nbd.name \
--cc=daniel@makrotopia.org \
--cc=hauke@hauke-m.de \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox