* [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags
@ 2025-06-24 2:07 Pei Xiao
2025-06-24 2:28 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: Pei Xiao @ 2025-06-24 2:07 UTC (permalink / raw)
To: pkshih, linux-wireless, linux-kernel; +Cc: Pei Xiao
This silences the following coccinelle warning:
WARNING: sum of probable bitmasks, consider |
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
drivers/net/wireless/realtek/rtw88/coex.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index 64904278ddad..37788aca200b 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1500,23 +1500,23 @@ static u8 rtw_coex_algorithm(struct rtw_dev *rtwdev)
case BPM_HFP:
algorithm = COEX_ALGO_HFP;
break;
- case BPM_HID:
- case BPM_HFP + BPM_HID:
+ case BPM_HID:
+ case BPM_HFP | BPM_HID:
algorithm = COEX_ALGO_HID;
break;
- case BPM_HFP + BPM_A2DP:
- case BPM_HID + BPM_A2DP:
- case BPM_HFP + BPM_HID + BPM_A2DP:
+ case BPM_HFP | BPM_A2DP:
+ case BPM_HID | BPM_A2DP:
+ case BPM_HFP | BPM_HID | BPM_A2DP:
algorithm = COEX_ALGO_A2DP_HID;
break;
- case BPM_HFP + BPM_PAN:
- case BPM_HID + BPM_PAN:
- case BPM_HFP + BPM_HID + BPM_PAN:
+ case BPM_HFP | BPM_PAN:
+ case BPM_HID | BPM_PAN:
+ case BPM_HFP | BPM_HID | BPM_PAN:
algorithm = COEX_ALGO_PAN_HID;
break;
- case BPM_HFP + BPM_A2DP + BPM_PAN:
- case BPM_HID + BPM_A2DP + BPM_PAN:
- case BPM_HFP + BPM_HID + BPM_A2DP + BPM_PAN:
+ case BPM_HFP | BPM_A2DP | BPM_PAN:
+ case BPM_HID | BPM_A2DP | BPM_PAN:
+ case BPM_HFP | BPM_HID | BPM_A2DP | BPM_PAN:
algorithm = COEX_ALGO_A2DP_PAN_HID;
break;
case BPM_PAN:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags
2025-06-24 2:07 [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags Pei Xiao
@ 2025-06-24 2:28 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2025-06-24 2:28 UTC (permalink / raw)
To: Pei Xiao, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Pei Xiao <xiaopei01@kylinos.cn> wrote:
> This silences the following coccinelle warning:
> WARNING: sum of probable bitmasks, consider |
>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
> drivers/net/wireless/realtek/rtw88/coex.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
> index 64904278ddad..37788aca200b 100644
> --- a/drivers/net/wireless/realtek/rtw88/coex.c
> +++ b/drivers/net/wireless/realtek/rtw88/coex.c
> @@ -1500,23 +1500,23 @@ static u8 rtw_coex_algorithm(struct rtw_dev *rtwdev)
> case BPM_HFP:
> algorithm = COEX_ALGO_HFP;
> break;
> - case BPM_HID:
> - case BPM_HFP + BPM_HID:
> + case BPM_HID:
> + case BPM_HFP | BPM_HID:
> algorithm = COEX_ALGO_HID;
> break;
> - case BPM_HFP + BPM_A2DP:
> - case BPM_HID + BPM_A2DP:
> - case BPM_HFP + BPM_HID + BPM_A2DP:
> + case BPM_HFP | BPM_A2DP:
> + case BPM_HID | BPM_A2DP:
> + case BPM_HFP | BPM_HID | BPM_A2DP:
> algorithm = COEX_ALGO_A2DP_HID;
> break;
> - case BPM_HFP + BPM_PAN:
> - case BPM_HID + BPM_PAN:
> - case BPM_HFP + BPM_HID + BPM_PAN:
> + case BPM_HFP | BPM_PAN:
> + case BPM_HID | BPM_PAN:
> + case BPM_HFP | BPM_HID | BPM_PAN:
Please just replace '+' by '|'. Keep spaces. People can be easier to see the
combination of BT profiles.
> algorithm = COEX_ALGO_PAN_HID;
> break;
> - case BPM_HFP + BPM_A2DP + BPM_PAN:
> - case BPM_HID + BPM_A2DP + BPM_PAN:
> - case BPM_HFP + BPM_HID + BPM_A2DP + BPM_PAN:
> + case BPM_HFP | BPM_A2DP | BPM_PAN:
> + case BPM_HID | BPM_A2DP | BPM_PAN:
> + case BPM_HFP | BPM_HID | BPM_A2DP | BPM_PAN:
> algorithm = COEX_ALGO_A2DP_PAN_HID;
> break;
> case BPM_PAN:
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-24 2:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-24 2:07 [PATCH] wifi: rtw88: coex: Use bitwise instead of arithmetic operator for flags Pei Xiao
2025-06-24 2:28 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox