From: Arnd Bergmann <arnd@arndb.de>
To: Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings
Date: Mon, 09 Mar 2015 20:50:09 +0100 [thread overview]
Message-ID: <9217056.Z3urqp19oZ@wuerfel> (raw)
In-Reply-To: <1425915402-10012-3-git-send-email-eliad@wizery.com>
On Monday 09 March 2015 17:36:42 Eliad Peller wrote:
> --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts
> @@ -64,4 +64,13 @@
> vmmc-supply = <&lbep5clwmc_wlen>;
> bus-width = <4>;
> non-removable;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + wlcore: wlcore@2 {
> + compatible = "ti,wl1835";
> + reg = <2>;
> + interrupt-parent = <&gpio5>;
> + interrupts = <8 IRQ_TYPE_NONE>;
> + };
>
Why IRQ_TYPE_NONE?
I was expecting you to remove all calls to legacy_init_wl12xx from this file,
including the ones for wl12xx aside from the wl18xx ones you removed, but
if that's enough to clean out the platform_data handling from the wlcore
driver, it's good enough as a start.
Arnd
next prev parent reply other threads:[~2015-03-09 19:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 15:36 [PATCH v5 1/3] dt: bindings: add wl18xx wireless device Eliad Peller
2015-03-09 15:36 ` [PATCH v5 2/3] wl18xx: add basic device-tree support Eliad Peller
2015-03-09 19:47 ` Arnd Bergmann
2015-03-11 0:34 ` Javier Martinez Canillas
2015-03-11 9:51 ` Arnd Bergmann
2015-03-11 10:05 ` Javier Martinez Canillas
2015-03-11 10:32 ` Arnd Bergmann
2015-03-11 11:50 ` Eliad Peller
2015-03-09 15:36 ` [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings Eliad Peller
2015-03-09 19:50 ` Arnd Bergmann [this message]
2015-03-09 21:03 ` Eliad Peller
2015-03-09 22:49 ` Tony Lindgren
2015-03-10 11:00 ` Eliad Peller
2015-03-10 14:11 ` Arnd Bergmann
2015-03-10 14:28 ` Tony Lindgren
2015-03-10 15:48 ` Arnd Bergmann
2015-03-10 15:55 ` Tony Lindgren
2015-03-10 14:31 ` Eliad Peller
2015-03-10 15:52 ` Arnd Bergmann
2015-03-10 16:11 ` Eliad Peller
2015-03-10 16:18 ` Tony Lindgren
2015-03-10 17:01 ` Eliad Peller
2015-03-10 17:35 ` Tony Lindgren
2015-03-10 19:49 ` Arnd Bergmann
2015-03-11 1:00 ` Javier Martinez Canillas
2015-03-11 9:53 ` Arnd Bergmann
2015-03-11 11:34 ` Javier Martinez Canillas
2015-03-11 12:12 ` Eliad Peller
2015-03-11 13:13 ` Arnd Bergmann
2015-03-11 12:40 ` Arnd Bergmann
2015-03-11 13:07 ` Javier Martinez Canillas
2015-03-11 13:17 ` Arnd Bergmann
2015-03-11 13:21 ` Javier Martinez Canillas
2015-03-11 13:38 ` Eliad Peller
2015-03-11 15:11 ` Tony Lindgren
2015-03-10 14:34 ` Sekhar Nori
2015-03-10 15:54 ` Arnd Bergmann
2015-03-11 0:28 ` Javier Martinez Canillas
2015-03-11 1:19 ` Javier Martinez Canillas
2015-03-11 11:59 ` Eliad Peller
2015-03-11 12:07 ` Javier Martinez Canillas
2015-03-11 11:54 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9217056.Z3urqp19oZ@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox