From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A7BC433E0 for ; Thu, 14 Jan 2021 10:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A07C23A3A for ; Thu, 14 Jan 2021 10:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728462AbhANKY4 (ORCPT ); Thu, 14 Jan 2021 05:24:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbhANKY4 (ORCPT ); Thu, 14 Jan 2021 05:24:56 -0500 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED27C061573 for ; Thu, 14 Jan 2021 02:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lbn6cYCk9/muYNK6QM9qsrM6esnGSsnu6m/z0AGuWLw=; b=LUS3TKKsfynbqt6gqpfWzogLg6 /1F7pqWim0z+f04zNnWgrs3c5GCD4pAZ3J3ko3NkVkjr9s1EDXcfQ0mj4DT3Xs1yRCzy39pCJkRW0 a5GsRtLoR++p0+6/JsB+AAzZqeW8uv+TMfa+VRnCvXFd6yqcixEc7cfG6C+smnHeuwbw=; Received: from p54ae91f2.dip0.t-ipconnect.de ([84.174.145.242] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1kzznJ-00072a-6U; Thu, 14 Jan 2021 11:23:57 +0100 Subject: Re: [PATCH 3/4] mt76: mt7915: add support for continuous tx in testmode To: Shayne Chen Cc: linux-wireless , Lorenzo Bianconi , Ryder Lee , Evelyn Tsai , linux-mediatek References: <20210105113045.17815-1-shayne.chen@mediatek.com> <20210105113045.17815-3-shayne.chen@mediatek.com> From: Felix Fietkau Message-ID: <926cb2f7-e66f-6804-a0ff-5fbd62193c59@nbd.name> Date: Thu, 14 Jan 2021 11:23:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210105113045.17815-3-shayne.chen@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-01-05 12:30, Shayne Chen wrote: > Implement continuous tx state for MT7915 NIC testmode. > > Signed-off-by: Shayne Chen > --- > .../net/wireless/mediatek/mt76/mt7915/mcu.c | 3 +- > .../net/wireless/mediatek/mt76/mt7915/mcu.h | 1 + > .../wireless/mediatek/mt76/mt7915/testmode.c | 160 ++++++++++++++++-- > .../wireless/mediatek/mt76/mt7915/testmode.h | 40 +++++ > 4 files changed, 192 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > index e5af42c70e12..68b170308c4a 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c > @@ -469,15 +475,144 @@ static void > mt7915_tm_set_rx_frames(struct mt7915_phy *phy, bool en) > { > struct mt7915_dev *dev = phy->dev; > - if (en) { > - mutex_unlock(&dev->mt76.mutex); > - mt7915_set_channel(phy); > - mutex_lock(&dev->mt76.mutex); > + if (en) > + mt7915_tm_update_channel(phy); > + > + mt7915_tm_set_trx(phy, TM_MAC_RX_RXV, en); This leaves dev as an unused variable. I'll fix it up locally. - Felix