From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 03/10] nl80211: add HE 6 GHz Band Capability support
Date: Wed, 29 Apr 2020 17:04:51 -0700 [thread overview]
Message-ID: <92e6776c460982184b3d8077a4a3cc1a@codeaurora.org> (raw)
In-Reply-To: <56500fd2b7c6b54e904567ba27171542027f2aea.camel@sipsolutions.net>
On 2020-04-29 07:28, Johannes Berg wrote:
> On Fri, 2020-04-24 at 15:41 -0700, Rajkumar Manoharan wrote:
>> Define new structures for HE 6 GHz band capabilities as per
>
> per?
>
Oops.. My bad. Accidentally removed the commit log.
>> include/linux/ieee80211.h | 57
>> ++++++++++++++++++++++++++++++++++++++++++++
>> include/net/cfg80211.h | 2 ++
>> include/uapi/linux/nl80211.h | 6 +++++
>> net/wireless/nl80211.c | 14 +++++++++++
>
> This is a bit mixed up, I'd prefer the raw ieee80211.h definitions in a
> separate patch.
>
Sure.
>> + [NL80211_ATTR_HE_6GHZ_CAPABILITY] = {
>> + .type = NLA_EXACT_LEN_WARN,
>> + .len = NL80211_HE_6GHZ_CAPABILITY_LEN,
>> + },
>
> Shouldn't use _WARN for a new attribute. Just reject it if userspace
> gets it wrong.
>
Done. :)
>> @@ -6177,6 +6185,12 @@ static int nl80211_new_station(struct sk_buff
>> *skb, struct genl_info *info)
>> return -EINVAL;
>> }
>>
>> + /* Ensure that HT/VHT capabilities are not set for 6 GHz HE STA */
>> + if (params.he_6ghz_capa) {
>> + params.ht_capa = NULL;
>> + params.vht_capa = NULL;
>> + }
>
> IMHO better to reject (with a message)
>
Got it.
-Rajkumar
next prev parent reply other threads:[~2020-04-30 0:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 22:41 [PATCH 00/10] mac80211: add 6 GHz IEs support Rajkumar Manoharan
2020-04-24 22:41 ` [PATCH 01/10] mac80211: fix memory overlap due to variable length param Rajkumar Manoharan
2020-04-24 22:41 ` [PATCH 02/10] cfg80211: validate 6 GHz chandef Rajkumar Manoharan
2020-04-29 14:26 ` Johannes Berg
2020-04-30 0:02 ` Rajkumar Manoharan
2020-04-30 19:54 ` Johannes Berg
2020-04-24 22:41 ` [PATCH 03/10] nl80211: add HE 6 GHz Band Capability support Rajkumar Manoharan
2020-04-29 14:28 ` Johannes Berg
2020-04-30 0:04 ` Rajkumar Manoharan [this message]
2020-04-24 22:41 ` [PATCH 04/10] mac80211: add HE 6 GHz Band Capabilities into parse extension Rajkumar Manoharan
2020-04-24 22:41 ` [PATCH 05/10] mac80211: handle HE 6 GHz Capability in HE STA processing Rajkumar Manoharan
2020-04-29 14:31 ` Johannes Berg
2020-04-30 0:11 ` Rajkumar Manoharan
2020-04-24 22:41 ` [PATCH 06/10] mac80211: add HE 6 GHz Band Capability IE in assoc. request Rajkumar Manoharan
2020-04-29 14:33 ` Johannes Berg
2020-04-30 0:14 ` Rajkumar Manoharan
2020-04-30 19:52 ` Johannes Berg
2020-04-24 22:41 ` [PATCH 07/10] mac80211: build HE operation with 6 GHz oper information Rajkumar Manoharan
2020-04-24 22:41 ` [PATCH 08/10] mac80211: do not allow HT/VHT IEs in 6 GHz mesh mode Rajkumar Manoharan
2020-04-24 22:41 ` [PATCH 09/10] mac80211: determine chantype from HE operation in 6 GHz Rajkumar Manoharan
2020-04-29 14:34 ` Johannes Berg
2020-04-30 0:18 ` Rajkumar Manoharan
2020-04-30 19:53 ` Johannes Berg
2020-04-24 22:41 ` [PATCH 10/10] ath11k: build HE 6 GHz capability Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92e6776c460982184b3d8077a4a3cc1a@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).