linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>, "Kalle Valo" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
	<brcm80211-dev-list.pdl@broadcom.com>,
	"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
	<brcm80211-dev-list.pdl@broadcom.com>,
	brcm80211-dev-list@cypress.com,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH wireless-drivers-next] brcmfmac: add basic validation of shared RAM address
Date: Thu, 21 Feb 2019 09:59:19 +0100	[thread overview]
Message-ID: <92e8bf1e-3be9-96f2-93e9-ac504a609929@broadcom.com> (raw)
In-Reply-To: <CACna6rwwDN6svzWMGbxYXDp5CN8C=A=fV224QcfoLcACQQgLDA@mail.gmail.com>

On 2/21/2019 9:01 AM, Rafał Miłecki wrote:
> On Wed, 20 Feb 2019 at 11:31, Rafał Miłecki <zajec5@gmail.com> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> While experimenting with firmware loading I ended up in a state of
>> firmware reporting shared RAM address 0x04000001. It was causing:
>> [   94.448015] Unable to handle kernel paging request at virtual address cd680001
>> due to reading out of the mapped memory.
>>
>> This patch adds some basic validation to avoid kernel crashes due to the
>> unexpected firmware behavior.
> 
> For a reference for the further hackers. That has been caused by a
> BCMA_CORE_SYS_MEM core on my BCM4366/4 not being up.

Thanks, Rafał

Does that happen all the time or in some specific scenario. Anyway, it 
seems like we need to add a check in brcmf_chip_sysmem_ramsize() and 
bringup the core if needed. Although, I am curious in what the state the 
other cores are at that time. Might need a chip-wide reset.

Regards,
Arend

  reply	other threads:[~2019-02-21  8:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-20 10:30 [PATCH wireless-drivers-next] brcmfmac: add basic validation of shared RAM address Rafał Miłecki
2019-02-20 12:49 ` Arend Van Spriel
2019-02-20 17:55 ` Kalle Valo
2019-02-21  8:01 ` Rafał Miłecki
2019-02-21  8:59   ` Arend Van Spriel [this message]
2019-02-21  9:27     ` Rafał Miłecki
2019-02-21 10:30       ` Arend Van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92e8bf1e-3be9-96f2-93e9-ac504a609929@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211-dev-list@cypress.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).