From: shayne.chen@mediatek.com
To: "nbd@nbd.name" <nbd@nbd.name>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Bo Jiao (焦波)" <Bo.Jiao@mediatek.com>,
"Evelyn Tsai (蔡珊鈺)" <Evelyn.Tsai@mediatek.com>,
"lorenzo@kernel.org" <lorenzo@kernel.org>,
"Ryder Lee" <Ryder.Lee@mediatek.com>,
"Henry Yen (顏修溫)" <Henry.Yen@mediatek.com>
Subject: Re: [PATCH 10/10] wifi: mt76: mt7996: add sanity check for NAPI schedule
Date: Mon, 8 Apr 2024 05:57:42 +0000 [thread overview]
Message-ID: <93e25a8325d33a30d9ef288bb8904fb5ba3db711.camel@mediatek.com> (raw)
In-Reply-To: <8fe81cdf-5807-4d6b-9bad-7a45208cd15a@nbd.name>
On Wed, 2024-04-03 at 12:57 +0200, Felix Fietkau wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 20.03.24 12:09, Shayne Chen wrote:
> > From: Henry Yen <henry.yen@mediatek.com>
> >
> > It's observed that host driver might occasionally receive
> > interrupts from unexpected Rx ring, whose Rx NAPI hasn't been
> > prepared yet. Under such situation, __napi_poll crash issue
> > would occur, so we add a sanity check to prevent it.
> >
> > Without this patch, we might encounter kernel crash issue
> > especially in WED-on & RRO-on software path.
>
> Does this issue occur even with Lorenzo's fix "wifi: mt76: mt7996:
> fix
> uninitialized variable in mt7996_irq_tasklet()"?
>
They achieve the same purpose, please drop this patch.
Thanks,
Shayne
> - Felix
prev parent reply other threads:[~2024-04-08 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 11:09 [PATCH 01/10] wifi: mt76: connac: use peer address for station BMC entry Shayne Chen
2024-03-20 11:09 ` [PATCH 02/10] wifi: mt76: mt7996: disable rx header translation for " Shayne Chen
2024-03-20 11:09 ` [PATCH 03/10] wifi: mt76: mt7996: set RCPI value in rate control command Shayne Chen
2024-03-20 11:09 ` [PATCH 04/10] wifi: mt76: connac: enable HW CSO module for mt7996 Shayne Chen
2024-03-20 11:09 ` [PATCH 05/10] wifi: mt76: mt7996: fix non-main BSS no beacon issue for MBSS scenario Shayne Chen
2024-03-20 11:09 ` [PATCH 06/10] wifi: mt76: mt7996: fix potential memory leakage when reading chip temperature Shayne Chen
2024-03-20 11:09 ` [PATCH 07/10] wifi: mt76: connac: enable critical packet mode support for mt7992 Shayne Chen
2024-03-20 11:09 ` [PATCH 08/10] wifi: mt76: mt7996: add sanity checks for background radar trigger Shayne Chen
2024-03-20 11:09 ` [PATCH 09/10] wifi: mt76: mt7996: let upper layer handle MGMT frame protection Shayne Chen
2024-04-03 10:56 ` Felix Fietkau
2024-04-08 6:07 ` shayne.chen
2024-03-20 11:09 ` [PATCH 10/10] wifi: mt76: mt7996: add sanity check for NAPI schedule Shayne Chen
2024-04-03 10:57 ` Felix Fietkau
2024-04-08 5:57 ` shayne.chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93e25a8325d33a30d9ef288bb8904fb5ba3db711.camel@mediatek.com \
--to=shayne.chen@mediatek.com \
--cc=Bo.Jiao@mediatek.com \
--cc=Evelyn.Tsai@mediatek.com \
--cc=Henry.Yen@mediatek.com \
--cc=Ryder.Lee@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox