RE: [PATCH rtw-next] wifi: rtw88: WARN only once in rtw_phy_get_tx_power_limit()

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> This function WARNs when the wifi band, channel number, channel width,
> rate, or RF path are invalid. Two or three people have reported that it
> floods the kernel log with warnings because they try to switch to
> invalid channel numbers, like 130.
> 
> One warning is probably enough, so turn WARN into WARN_ONCE.
> 
> Closes: https://github.com/lwfinger/rtw88/issues/428

As the issue says "invalid arguments, band=1, bw=2, path=1, rate=83, ch=130",
I think it operates on bandwidth 80MHz and primary channel 130. 
But I don't see 20MHz primary channel, for example [1]. 

Can we stop using this channel at set_channel() ahead to avoid this error?

[1] https://en.wikipedia.org/wiki/List_of_WLAN_channels


> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
>  drivers/net/wireless/realtek/rtw88/phy.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
> index e2ac5c6fd500..2a3929561664 100644
> --- a/drivers/net/wireless/realtek/rtw88/phy.c
> +++ b/drivers/net/wireless/realtek/rtw88/phy.c
> @@ -2210,8 +2210,8 @@ static s8 rtw_phy_get_tx_power_limit(struct rtw_dev *rtwdev, u8 band,
>         return power_limit;
> 
>  err:
> -       WARN(1, "invalid arguments, band=%d, bw=%d, path=%d, rate=%d, ch=%d\n",
> -            band, bw, rf_path, rate, channel);
> +       WARN_ONCE(1, "invalid arguments, band=%d, bw=%d, path=%d, rate=%d, ch=%d\n",
> +                 band, bw, rf_path, rate, channel);
>         return (s8)rtwdev->chip->max_power_index;

I feel this will be a problem if max_power_index is adopted.
The power is too high. 

>  }
> 
> --
> 2.52.0