From: Seevalamuthu Mariappan <seevalam@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: send only vlan group traffics in 80211 xmit path
Date: Wed, 19 Aug 2020 13:23:03 +0530 [thread overview]
Message-ID: <94f16e76ca54dc175a756a51a4907a1c@codeaurora.org> (raw)
In-Reply-To: <4abebda6ee90ce59b9dc5121b07d1954841351c7.camel@sipsolutions.net>
Hi Johannes,
On 2020-08-19 12:24, Johannes Berg wrote:
> On Wed, 2020-08-19 at 12:15 +0530, Seevalamuthu Mariappan wrote:
>> AP-VLAN multicast/broadcast packets are expected to be encrypted
>> in software.
>
> Err. Expected by whom?
Not an expectation exactly. As of now, AP-VLAN multicast/broadcast
packets are encrypted in mac80211 itself. So these packets needs to go
through 80211_xmit path. This change is just to redirect the other
packets (unicast) to 802.3 xmit path if hw encap is enabled on AP
interface.
>
>> Those packets should follow 802.11 xmit path.
>
> You should explain why ...
>
>> -void __ieee80211_subif_start_xmit(struct sk_buff *skb,
>> - struct net_device *dev,
>> - u32 info_flags,
>> - u32 ctrl_flags,
>> - u64 *cookie)
>
> There's no way I can review this if you move the whole function while
> making a small change to it ...
Will split into two patches, one having function movement and another
patch having the actual change.
>
> johannes
Thanks,
Seevalamuthu M
next prev parent reply other threads:[~2020-08-19 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 6:45 [PATCH] mac80211: send only vlan group traffics in 80211 xmit path Seevalamuthu Mariappan
2020-08-19 6:54 ` Johannes Berg
2020-08-19 7:53 ` Seevalamuthu Mariappan [this message]
2020-08-19 9:52 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94f16e76ca54dc175a756a51a4907a1c@codeaurora.org \
--to=seevalam@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).